[GitHub] [hudi] danny0405 commented on a diff in pull request #7571: [HUDI-4710]Fix flaky: TestKeyRangeLookupTree#testFileGroupLookUpManyEntriesWithSameStartValue

2022-12-29 Thread GitBox 


danny0405 commented on code in PR #7571:
URL: https://github.com/apache/hudi/pull/7571#discussion_r1059227583


##
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/index/bloom/TestKeyRangeLookupTree.java:
##
@@ -68,7 +68,7 @@ public void 
testFileGroupLookUpManyEntriesWithSameStartValue() {
 updateExpectedMatchesToTest(toInsert);
 keyRangeLookupTree.insert(toInsert);
 for (int i = 0; i < 10; i++) {
-  endKey += 1 + RANDOM.nextInt(100);
+  endKey += 1 + RANDOM.nextInt(50);
   toInsert = new KeyRangeNode(startKey, Long.toString(endKey), 
UUID.randomUUID().toString());
   updateExpectedMatchesToTest(toInsert);

Review Comment:
   Yeah, the fix works, it is better if we can fix the record key comparing 
with Long instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] danny0405 commented on a diff in pull request #7571: [HUDI-4710]Fix flaky: TestKeyRangeLookupTree#testFileGroupLookUpManyEntriesWithSameStartValue

2022-12-28 Thread GitBox 


danny0405 commented on code in PR #7571:
URL: https://github.com/apache/hudi/pull/7571#discussion_r1058706836


##
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/index/bloom/TestKeyRangeLookupTree.java:
##
@@ -68,7 +68,7 @@ public void 
testFileGroupLookUpManyEntriesWithSameStartValue() {
 updateExpectedMatchesToTest(toInsert);
 keyRangeLookupTree.insert(toInsert);
 for (int i = 0; i < 10; i++) {
-  endKey += 1 + RANDOM.nextInt(100);
+  endKey += 1 + RANDOM.nextInt(50);
   toInsert = new KeyRangeNode(startKey, Long.toString(endKey), 
UUID.randomUUID().toString());
   updateExpectedMatchesToTest(toInsert);

Review Comment:
   Can the `KeyRangeNode` be fixed to compare with `Long` instead of `String` 
here ? The fix is fragile because it is related with the key value range. And 
we can not always keep ensurence that the key is smaller than `1024`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org