[GitHub] [hudi] danny0405 commented on a diff in pull request #8665: [HUDI-6190] Fix the default value of RECORD_KEY_FIELD.

[via GitHub]

danny0405 commented on code in PR #8665:
URL: https://github.com/apache/hudi/pull/8665#discussion_r1188062501


##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##
@@ -411,7 +411,7 @@ private FlinkOptions() {
   public static final ConfigOption RECORD_KEY_FIELD = ConfigOptions
   .key(KeyGeneratorOptions.RECORDKEY_FIELD_NAME.key())
   .stringType()
-  .defaultValue("uuid")
+  .defaultValue("")

Review Comment:
   Yeah, but make sure to go through the validations in `HoodieTableFactory` to 
keep the validity.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] danny0405 commented on a diff in pull request #8665: [HUDI-6190] Fix the default value of RECORD_KEY_FIELD.

[via GitHub]

danny0405 commented on code in PR #8665:
URL: https://github.com/apache/hudi/pull/8665#discussion_r1187312723


##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##
@@ -411,7 +411,7 @@ private FlinkOptions() {
   public static final ConfigOption RECORD_KEY_FIELD = ConfigOptions
   .key(KeyGeneratorOptions.RECORDKEY_FIELD_NAME.key())
   .stringType()
-  .defaultValue("uuid")
+  .defaultValue("")

Review Comment:
   noDefaultValue?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org