[GitHub] [hudi] danny0405 commented on issue #3266: [SUPPORT] Upsert data with an identical record key and pre-combine field
danny0405 commented on issue #3266: URL: https://github.com/apache/hudi/issues/3266#issuecomment-907592994 Hi @Rap70r , the 0.9.0 has been released so i would just close the issue as resolved, if you have other problems, feel free to reopen it again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] danny0405 commented on issue #3266: [SUPPORT] Upsert data with an identical record key and pre-combine field
danny0405 commented on issue #3266: URL: https://github.com/apache/hudi/issues/3266#issuecomment-904291403 The delete is still problematic for MOR table, because Hudi always writes the DELETE data block after the DATA block, the DELETE block does not record the event time, and the reader always read the DELETE block after, so even a DELETE message has smaller event time than INSERT message, the INSERT message is still deleted. We have fixed the sequence for COW table though in the 0.9 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] danny0405 commented on issue #3266: [SUPPORT] Upsert data with an identical record key and pre-combine field
danny0405 commented on issue #3266: URL: https://github.com/apache/hudi/issues/3266#issuecomment-896450563 The PR is merged, please verify again if your issue is resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] danny0405 commented on issue #3266: [SUPPORT] Upsert data with an identical record key and pre-combine field
danny0405 commented on issue #3266: URL: https://github.com/apache/hudi/issues/3266#issuecomment-880349759 Yes, the PR would be merged soon once the CI tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] danny0405 commented on issue #3266: [SUPPORT] Upsert data with an identical record key and pre-combine field
danny0405 commented on issue #3266: URL: https://github.com/apache/hudi/issues/3266#issuecomment-878914764 I will, but only after this patch for `#preCombine` method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] danny0405 commented on issue #3266: [SUPPORT] Upsert data with an identical record key and pre-combine field
danny0405 commented on issue #3266: URL: https://github.com/apache/hudi/issues/3266#issuecomment-878891968 See this PR: https://github.com/apache/hudi/pull/3267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] danny0405 commented on issue #3266: [SUPPORT] Upsert data with an identical record key and pre-combine field
danny0405 commented on issue #3266: URL: https://github.com/apache/hudi/issues/3266#issuecomment-878876274 Thanks for the feedback, i guess this is because our payload does not choose the latest data when the preCombine field are the same. See `OverwriteWithLatestAvroPayload.preCombine`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
