[GitHub] [hudi] danny0405 commented on pull request #7584: [HUDI-5205] Support Flink 1.16.0

2023-01-03 Thread GitBox


danny0405 commented on PR #7584:
URL: https://github.com/apache/hudi/pull/7584#issuecomment-1370531069

   Thanks for the contribution, I have reviewed again and created another patch:
   
[5205.patch.zip](https://github.com/apache/hudi/files/10341889/5205.patch.zip)
   
   The tests failed because the `JsonRowDataDeserializationSchema` is 
refactorted where the `#open` method must be called for some JSON 
infrustructures initialization.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] danny0405 commented on pull request #7584: [HUDI-5205] Support Flink 1.16.0

2023-01-02 Thread GitBox


danny0405 commented on PR #7584:
URL: https://github.com/apache/hudi/pull/7584#issuecomment-1369398865

   Thanks for the contribution, I have reviewed and applied a patch here:
   [5205.zip](https://github.com/apache/hudi/files/10334376/5205.zip)
   
   You can apply the patch with cmd: `git apply ${patch_path}`
   Then force push the branch with cmd: `git push ${branch_name} --force`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org