[GitHub] [hudi] danny0405 commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
danny0405 commented on PR #8432: URL: https://github.com/apache/hudi/pull/8432#issuecomment-1525159081 > @danny0405 integrated your patch. Now I need to: > > * confirm the test breaks without the change > * assert not throw npe Yeah, that makes sense, I run the 2 tests locally and they can pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
danny0405 commented on PR #8432: URL: https://github.com/apache/hudi/pull/8432#issuecomment-1524476805 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
danny0405 commented on PR #8432: URL: https://github.com/apache/hudi/pull/8432#issuecomment-1522728301 Thanks for the fix, I have reviewed and created a patch: [6072.patch.zip](https://github.com/apache/hudi/files/11328753/6072.patch.zip) You can rebase with the latest master, apply the patch and then force-push with the branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
danny0405 commented on PR #8432: URL: https://github.com/apache/hudi/pull/8432#issuecomment-1521663805 > @danny0405 added stuff for tests, bug cannot setup intellij to debug/run tests locally (pain following the https://hudi.apache.org/contribute/developer-setup) Could we fix line 191 instead, that could fix all the data type with null values, covering also the atomic data types. You can also use the `mvn test` cmd for testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
danny0405 commented on PR #8432: URL: https://github.com/apache/hudi/pull/8432#issuecomment-1509606563 > Tests based on the spark datasource api (similar to the eg in the OP) or do you have a better idea? Either data sorurce api or sql should be fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
