[GitHub] [hudi] danny0405 commented on pull request #9255: [HUDI-6503] Make TableServiceClient's txnManager consistent with Writ…
danny0405 commented on PR #9255: URL: https://github.com/apache/hudi/pull/9255#issuecomment-1666717120 Let's move this out of 0.14.0 because it's only a code refactoring. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #9255: [HUDI-6503] Make TableServiceClient's txnManager consistent with Writ…
danny0405 commented on PR #9255: URL: https://github.com/apache/hudi/pull/9255#issuecomment-1650874179 Okay, a static lock mapping makes sense to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #9255: [HUDI-6503] Make TableServiceClient's txnManager consistent with Writ…
danny0405 commented on PR #9255: URL: https://github.com/apache/hudi/pull/9255#issuecomment-1650853733 > I think about it again, and think that it’s okay to not pass the txtmanger Can you elaborate a little more why the table service client can hold a separate lock ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #9255: [HUDI-6503] Make TableServiceClient's txnManager consistent with Writ…
danny0405 commented on PR #9255: URL: https://github.com/apache/hudi/pull/9255#issuecomment-1647187480 [6503.patch.zip](https://github.com/apache/hudi/files/12141690/6503.patch.zip) Thanks for the contribution, I have reviewd and add some modifications ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org