[GitHub] [hudi] fsilent commented on a diff in pull request #7129: [MINOR] Support column type evolution for Hive
fsilent commented on code in PR #7129: URL: https://github.com/apache/hudi/pull/7129#discussion_r1013662127 ## hudi-spark-datasource/hudi-spark-common/pom.xml: ## @@ -222,6 +222,20 @@ test + + Review Comment: In my env spark is 3.x, dont need add hive dependency. But hudi master branch use spark 2.x default，so add hive dependency in hudi-hive-sync module -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] fsilent commented on a diff in pull request #7129: [MINOR] Support column type evolution for Hive
fsilent commented on code in PR #7129: URL: https://github.com/apache/hudi/pull/7129#discussion_r1013662127 ## hudi-spark-datasource/hudi-spark-common/pom.xml: ## @@ -222,6 +222,20 @@ test + + Review Comment: In my env spark is 3.x, dont need add hive dependency. But hudi master branch use spark 2.x default，so add hive dependency in hudi-hive-sync module -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] fsilent commented on a diff in pull request #7129: [MINOR] Support column type evolution for Hive
fsilent commented on code in PR #7129:
URL: https://github.com/apache/hudi/pull/7129#discussion_r1013541122
##
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieParquetInputFormat.java:
##
@@ -45,7 +46,8 @@
*/
@UseRecordReaderFromInputFormat
@UseFileSplitsFromInputFormat
-public class HoodieParquetInputFormat extends HoodieParquetInputFormatBase {
+public class HoodieParquetInputFormat extends HoodieParquetInputFormatBase
implements
+SelfDescribingInputFormatInterface {
Review Comment:
ok. has changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hudi] fsilent commented on a diff in pull request #7129: [MINOR] Support column type evolution for Hive
fsilent commented on code in PR #7129: URL: https://github.com/apache/hudi/pull/7129#discussion_r1013540860 ## hudi-spark-datasource/hudi-spark-common/pom.xml: ## @@ -222,6 +222,20 @@ test + + Review Comment: changed. now dont need to add hive dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] fsilent commented on a diff in pull request #7129: [MINOR] Support column type evolution for Hive
fsilent commented on code in PR #7129: URL: https://github.com/apache/hudi/pull/7129#discussion_r1013522502 ## hudi-spark-datasource/hudi-spark-common/pom.xml: ## @@ -222,6 +222,20 @@ test + + Review Comment: because support column type evolution for Hive we should let HoodieParquetInputFormat and HoodieParquetRealtimeInputFormat implements org.apache.hadoop.hive.ql.io.SelfDescribingInputFormatInterface. And in hudi-spark-datasource moudle, will load HoodieParquetInputFormat and HoodieParquetRealtimeInputFormat, but not found SelfDescribingInputFormatInterface  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] fsilent commented on a diff in pull request #7129: [MINOR] Support column type evolution for Hive
fsilent commented on code in PR #7129: URL: https://github.com/apache/hudi/pull/7129#discussion_r1013522502 ## hudi-spark-datasource/hudi-spark-common/pom.xml: ## @@ -222,6 +222,20 @@ test + + Review Comment: because support column type evolution for Hive we should let HoodieParquetInputFormat and HoodieParquetRealtimeInputFormat implements org.apache.hadoop.hive.ql.io.SelfDescribingInputFormatInterface. And in hudi-spark-datasource moudle, will load HoodieParquetInputFormat and HoodieParquetRealtimeInputFormat, but not found SelfDescribingInputFormatInterface  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
