[GitHub] [hudi] garyli1019 commented on a change in pull request #3238: [HUDI-2143] Tweak the default compaction target IO to 500GB when flin…

2021-07-10 Thread GitBox 


garyli1019 commented on a change in pull request #3238:
URL: https://github.com/apache/hudi/pull/3238#discussion_r667423248



##
File path: 
hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableFactory.java
##
@@ -199,6 +199,12 @@ private static void setupCleaningOptions(Configuration 
conf) {
   conf.setInteger(FlinkOptions.ARCHIVE_MIN_COMMITS, commitsToRetain + 10);
   conf.setInteger(FlinkOptions.ARCHIVE_MAX_COMMITS, commitsToRetain + 20);
 }
+if (conf.getBoolean(FlinkOptions.COMPACTION_SCHEDULE_ENABLED)

Review comment:
   sorry, a bit late on this. I don't have a strong objection here but 
slightly incline to not turning config inside the code.
   My point is that tweaking config is ok if the user wrote their own connector 
or wanted to reduce the overhead of having too many configs in their app. I do 
this in my app as well. But this is the official connector of Hudi, so I think 
we should keep the config as how it is.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] garyli1019 commented on a change in pull request #3238: [HUDI-2143] Tweak the default compaction target IO to 500GB when flin…

2021-07-08 Thread GitBox 


garyli1019 commented on a change in pull request #3238:
URL: https://github.com/apache/hudi/pull/3238#discussion_r666022649



##
File path: 
hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableFactory.java
##
@@ -199,6 +199,12 @@ private static void setupCleaningOptions(Configuration 
conf) {
   conf.setInteger(FlinkOptions.ARCHIVE_MIN_COMMITS, commitsToRetain + 10);
   conf.setInteger(FlinkOptions.ARCHIVE_MAX_COMMITS, commitsToRetain + 20);
 }
+if (conf.getBoolean(FlinkOptions.COMPACTION_SCHEDULE_ENABLED)

Review comment:
   why not just respect the config user-defined? this change the config 
without noticing anyone




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org