[GitHub] [hudi] houhang1005 commented on a diff in pull request #8665: [HUDI-6190] Fix the default value of RECORD_KEY_FIELD.

2023-05-09 Thread via GitHub 


houhang1005 commented on code in PR #8665:
URL: https://github.com/apache/hudi/pull/8665#discussion_r1188348972


##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##
@@ -411,7 +411,7 @@ private FlinkOptions() {
   public static final ConfigOption RECORD_KEY_FIELD = ConfigOptions
   .key(KeyGeneratorOptions.RECORDKEY_FIELD_NAME.key())
   .stringType()
-  .defaultValue("uuid")
+  .defaultValue("")

Review Comment:
   You are right, I will test the several situations, and then consider it is 
necessary or not to change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] houhang1005 commented on a diff in pull request #8665: [HUDI-6190] Fix the default value of RECORD_KEY_FIELD.

2023-05-08 Thread via GitHub 


houhang1005 commented on code in PR #8665:
URL: https://github.com/apache/hudi/pull/8665#discussion_r1187389766


##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##
@@ -411,7 +411,7 @@ private FlinkOptions() {
   public static final ConfigOption RECORD_KEY_FIELD = ConfigOptions
   .key(KeyGeneratorOptions.RECORDKEY_FIELD_NAME.key())
   .stringType()
-  .defaultValue("uuid")
+  .defaultValue("")

Review Comment:
   Hi , KeyGeneratorOptions.RECORDKEY_FIELD_NAME's default value is 
noDefaultValue(), I guess we can also change .defaultValue("")  to  
.noDefaultValue(). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org