[GitHub] [hudi] leesf commented on a diff in pull request #5737: [HUDI-4178][Stacked on 5733] Addressing performance regressions in Spark DataSourceV2 Integration
leesf commented on code in PR #5737: URL: https://github.com/apache/hudi/pull/5737#discussion_r889424940 ## hudi-spark-datasource/hudi-spark3/src/main/scala/org/apache/spark/sql/hudi/catalog/HoodieCatalog.scala: ## @@ -105,12 +106,16 @@ class HoodieCatalog extends DelegatingCatalogExtension case _ => catalogTable0 } -HoodieInternalV2Table( + +val v2Table = HoodieInternalV2Table( spark = spark, path = catalogTable.location.toString, catalogTable = Some(catalogTable), tableIdentifier = Some(ident.toString)) - case o => o +// TODO elaborate +v2Table.v1TableWrapper Review Comment: it means users no long able to write/read data when specifying HoodieCatalog if using V1Table since it has no capabilities. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] leesf commented on a diff in pull request #5737: [HUDI-4178][Stacked on 5733] Addressing performance regressions in Spark DataSourceV2 Integration
leesf commented on code in PR #5737: URL: https://github.com/apache/hudi/pull/5737#discussion_r889424940 ## hudi-spark-datasource/hudi-spark3/src/main/scala/org/apache/spark/sql/hudi/catalog/HoodieCatalog.scala: ## @@ -105,12 +106,16 @@ class HoodieCatalog extends DelegatingCatalogExtension case _ => catalogTable0 } -HoodieInternalV2Table( + +val v2Table = HoodieInternalV2Table( spark = spark, path = catalogTable.location.toString, catalogTable = Some(catalogTable), tableIdentifier = Some(ident.toString)) - case o => o +// TODO elaborate +v2Table.v1TableWrapper Review Comment: it means users no long able to write/read data when specifying HoodieCatalog -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
