[GitHub] [hudi] liujinhui1994 commented on pull request #2710: [RFC-20][HUDI-648] Implement error log/table for Datasource/DeltaStreamer/WriteClient/Compaction writes

2021-04-12 Thread GitBox 


liujinhui1994 commented on pull request #2710:
URL: https://github.com/apache/hudi/pull/2710#issuecomment-817658270


   @yanghua   @xushiyan  please help review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] liujinhui1994 commented on pull request #2710: [RFC-20][HUDI-648] Implement error log/table for Datasource/DeltaStreamer/WriteClient/Compaction writes

2021-03-31 Thread GitBox 


liujinhui1994 commented on pull request #2710:
URL: https://github.com/apache/hudi/pull/2710#issuecomment-810842963


   @lw309637554  Please help review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] liujinhui1994 commented on pull request #2710: [RFC-20][HUDI-648] Implement error log/table for Datasource/DeltaStreamer/WriteClient/Compaction writes

2021-03-30 Thread GitBox 


liujinhui1994 commented on pull request #2710:
URL: https://github.com/apache/hudi/pull/2710#issuecomment-810264676


   Ok
   
   
   
   
   
   -- Original --
   From: lw0090 ***@***.***
   Date: Tue,Mar 30,2021 9:38 PM
   To: apache/hudi ***@***.***
   Cc: liujinhui ***@***.***, Author ***@***.***
   Subject: Re: [apache/hudi] [RFC-20][HUDI-648] Implement error log/table for 
Datasource/DeltaStreamer/WriteClient/Compaction writes (#2710)
   
   
   
   
   

   @lw309637554 commented on this pull request.


   In 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
 +  /** +   * Error table configs. +   */ +  public boolean 
enableErrorTable() { +return 
Boolean.parseBoolean(props.getProperty(HoodieErrorTableConfig.ERROR_TABLE_ENABLE_PROP));
 +  } + +  public String getErrorTableBasePath() { +return 
props.getProperty(HoodieErrorTableConfig.ERROR_TABLE_BASE_PATH_PROP); +  } + +  
public String getErrorTableName() { +return 
props.getProperty(HoodieErrorTableConfig.ERROR_TABLE_NAME_PROP); +  } + +  
public int getErrorTableInsertParallelism() {  
   can move this to HoodieErrorTableConfig?

   —
   You are receiving this because you authored the thread.
   Reply to this email directly, view it on GitHub, or unsubscribe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] liujinhui1994 commented on pull request #2710: [RFC-20][HUDI-648] Implement error log/table for Datasource/DeltaStreamer/WriteClient/Compaction writes

2021-03-30 Thread GitBox 


liujinhui1994 commented on pull request #2710:
URL: https://github.com/apache/hudi/pull/2710#issuecomment-810264337


   Ok
   
   
   
   
   
   -- Original --
   From: lw0090 ***@***.***
   Date: Tue,Mar 30,2021 9:32 PM
   To: apache/hudi ***@***.***
   Cc: liujinhui ***@***.***, Author ***@***.***
   Subject: Re: [apache/hudi] [RFC-20][HUDI-648] Implement error log/table for 
Datasource/DeltaStreamer/WriteClient/Compaction writes (#2710)
   
   
   
   
   

   @lw309637554 commented on this pull request.


   In 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
 @@ -1032,6 +1033,37 @@ public String getWriteMetaKeyPrefixes() {  
return props.getProperty(WRITE_META_KEY_PREFIXES_PROP);}   +  /** +   * 
Error table configs. +   */ +  public boolean enableErrorTable() {  
   enableErrorTable- errorTableEnabled ?  this will be more unify

   —
   You are receiving this because you authored the thread.
   Reply to this email directly, view it on GitHub, or unsubscribe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org