[GitHub] [hudi] manojpec commented on pull request #4449: [HUDI-2763] Metadata table records - support for key deduplication based on hardcoded key field
manojpec commented on pull request #4449: URL: https://github.com/apache/hudi/pull/4449#issuecomment-1021682271 CI passed in the re-run - https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=5508&view=results -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] manojpec commented on pull request #4449: [HUDI-2763] Metadata table records - support for key deduplication based on hardcoded key field
manojpec commented on pull request #4449: URL: https://github.com/apache/hudi/pull/4449#issuecomment-1013560479 @prashantwason @vinothchandar After discussions, made HoodieHFileReader the single source of truth for all HFile schema related fields. HFileReader already tracks other fields and it is meaningful to move the key field also here. MetadataPayload and HFileDataBlock will refer to HFileReader for the key field. Passing the properties to HFileDataBlock can come in separate PR as suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
