[GitHub] [hudi] n3nash commented on a change in pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution
n3nash commented on a change in pull request #2012:
URL: https://github.com/apache/hudi/pull/2012#discussion_r487165310
##
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] bytes,
Schema schema) throws IOEx
* Convert serialized bytes back into avro record.
*/
public static GenericRecord bytesToAvro(byte[] bytes, Schema writerSchema,
Schema readerSchema) throws IOException {
Review comment:
@sathyaprakashg But like you mentioned, if you don't add namespace, you
see the type mismatch exception, right ?
##
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] bytes,
Schema schema) throws IOEx
* Convert serialized bytes back into avro record.
*/
public static GenericRecord bytesToAvro(byte[] bytes, Schema writerSchema,
Schema readerSchema) throws IOException {
Review comment:
@sathyaprakashg But like you mentioned, if you don't add namespace, you
see the type mismatch exception, right ? How are you planning to avoid adding
namespace but still not run into the type exception ?
##
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] bytes,
Schema schema) throws IOEx
* Convert serialized bytes back into avro record.
*/
public static GenericRecord bytesToAvro(byte[] bytes, Schema writerSchema,
Schema readerSchema) throws IOException {
Review comment:
@sathyaprakashg But like you mentioned, if you don't add namespace, you
see the type mismatch exception, right ?
##
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] bytes,
Schema schema) throws IOEx
* Convert serialized bytes back into avro record.
*/
public static GenericRecord bytesToAvro(byte[] bytes, Schema writerSchema,
Schema readerSchema) throws IOException {
Review comment:
@sathyaprakashg But like you mentioned, if you don't add namespace, you
see the type mismatch exception, right ? How are you planning to avoid adding
namespace but still not run into the type exception ?
##
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] bytes,
Schema schema) throws IOEx
* Convert serialized bytes back into avro record.
*/
public static GenericRecord bytesToAvro(byte[] bytes, Schema writerSchema,
Schema readerSchema) throws IOException {
Review comment:
@sathyaprakashg But like you mentioned, if you don't add namespace, you
see the type mismatch exception, right ?
##
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] bytes,
Schema schema) throws IOEx
* Convert serialized bytes back into avro record.
*/
public static GenericRecord bytesToAvro(byte[] bytes, Schema writerSchema,
Schema readerSchema) throws IOException {
Review comment:
@sathyaprakashg But like you mentioned, if you don't add namespace, you
see the type mismatch exception, right ? How are you planning to avoid adding
namespace but still not run into the type exception ?
##
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] bytes,
Schema schema) throws IOEx
* Convert serialized bytes back into avro record.
*/
public static GenericRecord bytesToAvro(byte[] bytes, Schema writerSchema,
Schema readerSchema) throws IOException {
Review comment:
@sathyaprakashg But like you mentioned, if you don't add namespace, you
see the type mismatch exception, right ?
##
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] bytes,
Schema schema) throws IOEx
* Convert serialized bytes back into avro record.
*/
public static GenericRecord bytesToAvro(byte[] bytes, Schema writerSchema,
Schema readerSchema) throws IOException {
Review comment:
@sathyaprakashg But like you mentioned, if you don't add namespace, you
see the type mismatch exception, right ? How are you planning to avoid adding
namespace but still not run into the type exception ?
##
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] bytes,
Schema schema) throws IOEx
* Convert serialized bytes back into avro record.
*/
public static GenericRecord b
[GitHub] [hudi] n3nash commented on a change in pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution
n3nash commented on a change in pull request #2012:
URL: https://github.com/apache/hudi/pull/2012#discussion_r487165310
##
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] bytes,
Schema schema) throws IOEx
* Convert serialized bytes back into avro record.
*/
public static GenericRecord bytesToAvro(byte[] bytes, Schema writerSchema,
Schema readerSchema) throws IOException {
Review comment:
@sathyaprakashg But like you mentioned, if you don't add namespace, you
see the type mismatch exception, right ?
##
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] bytes,
Schema schema) throws IOEx
* Convert serialized bytes back into avro record.
*/
public static GenericRecord bytesToAvro(byte[] bytes, Schema writerSchema,
Schema readerSchema) throws IOException {
Review comment:
@sathyaprakashg But like you mentioned, if you don't add namespace, you
see the type mismatch exception, right ? How are you planning to avoid adding
namespace but still not run into the type exception ?
##
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] bytes,
Schema schema) throws IOEx
* Convert serialized bytes back into avro record.
*/
public static GenericRecord bytesToAvro(byte[] bytes, Schema writerSchema,
Schema readerSchema) throws IOException {
Review comment:
@sathyaprakashg But like you mentioned, if you don't add namespace, you
see the type mismatch exception, right ?
##
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] bytes,
Schema schema) throws IOEx
* Convert serialized bytes back into avro record.
*/
public static GenericRecord bytesToAvro(byte[] bytes, Schema writerSchema,
Schema readerSchema) throws IOException {
Review comment:
@sathyaprakashg But like you mentioned, if you don't add namespace, you
see the type mismatch exception, right ? How are you planning to avoid adding
namespace but still not run into the type exception ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hudi] n3nash commented on a change in pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution
n3nash commented on a change in pull request #2012:
URL: https://github.com/apache/hudi/pull/2012#discussion_r487165310
##
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] bytes,
Schema schema) throws IOEx
* Convert serialized bytes back into avro record.
*/
public static GenericRecord bytesToAvro(byte[] bytes, Schema writerSchema,
Schema readerSchema) throws IOException {
Review comment:
@sathyaprakashg But like you mentioned, if you don't add namespace, you
see the type mismatch exception, right ? How are you planning to avoid adding
namespace but still not run into the type exception ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hudi] n3nash commented on a change in pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution
n3nash commented on a change in pull request #2012:
URL: https://github.com/apache/hudi/pull/2012#discussion_r487165310
##
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] bytes,
Schema schema) throws IOEx
* Convert serialized bytes back into avro record.
*/
public static GenericRecord bytesToAvro(byte[] bytes, Schema writerSchema,
Schema readerSchema) throws IOException {
Review comment:
@sathyaprakashg But like you mentioned, if you don't add namespace, you
see the type mismatch exception, right ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hudi] n3nash commented on a change in pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution
n3nash commented on a change in pull request #2012:
URL: https://github.com/apache/hudi/pull/2012#discussion_r485009679
##
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] bytes,
Schema schema) throws IOEx
* Convert serialized bytes back into avro record.
*/
public static GenericRecord bytesToAvro(byte[] bytes, Schema writerSchema,
Schema readerSchema) throws IOException {
Review comment:
How many places is this method being used ? Is adding namespace to the
reader schema backwards compatible for older data/schema written without the
namespace ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hudi] n3nash commented on a change in pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution
n3nash commented on a change in pull request #2012:
URL: https://github.com/apache/hudi/pull/2012#discussion_r485009679
##
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] bytes,
Schema schema) throws IOEx
* Convert serialized bytes back into avro record.
*/
public static GenericRecord bytesToAvro(byte[] bytes, Schema writerSchema,
Schema readerSchema) throws IOException {
Review comment:
How many places is this method being used ? Is adding namespace to the
reader schema backwards compatible for data/schema written without the
namespace ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
