[GitHub] [hudi] n3nash commented on pull request #1242: [HUDI-544] Archived commits command code cleanup
n3nash commented on pull request #1242: URL: https://github.com/apache/hudi/pull/1242#issuecomment-691203252 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] n3nash commented on pull request #1242: [HUDI-544] Archived commits command code cleanup
n3nash commented on pull request #1242: URL: https://github.com/apache/hudi/pull/1242#issuecomment-691203252 @hddong Extremely sorry, this fell through the crack, please rebase and I will merge this right after. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] n3nash commented on pull request #1242: [HUDI-544] Archived commits command code cleanup
n3nash commented on pull request #1242: URL: https://github.com/apache/hudi/pull/1242#issuecomment-691203252 @hddong Extremely sorry, this fell through the crack, please rebase and I will merge this right after. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] n3nash commented on pull request #1242: [HUDI-544] Archived commits command code cleanup
n3nash commented on pull request #1242: URL: https://github.com/apache/hudi/pull/1242#issuecomment-668905083 @hddong Sorry this fell through, please rebase and I will merge this asap This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] n3nash commented on pull request #1242: [HUDI-544] Archived commits command code cleanup
n3nash commented on pull request #1242: URL: https://github.com/apache/hudi/pull/1242#issuecomment-655266701 @hddong Please create a JIRA ticket here -> https://issues.apache.org/jira/projects/HUDI/issues and add the tag of documentation/release notes update. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] n3nash commented on pull request #1242: [HUDI-544] Archived commits command code cleanup
n3nash commented on pull request #1242: URL: https://github.com/apache/hudi/pull/1242#issuecomment-643382309 @hddong > @hddong I'm accepting and will merge after you create another ticket for us to add to the release notes that if someone was actually overriding HOODIE_ARCHIVELOG_FOLDER_PROP_NAME that was not being honored before and now will be honored for those cases it can break (since this is the right thing to do) This is what I had commented. So this change will break if someone was overriding this prop name and expecting that path to be used (but it was actually not since it was never used). can you open a ticket for us to add this to the release notes and we can merge then. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
