[GitHub] [hudi] nsivabalan commented on pull request #2111: [HUDI-1234] Insert new records regardless of small file when using insert operation
nsivabalan commented on pull request #2111: URL: https://github.com/apache/hudi/pull/2111#issuecomment-762613728 @vinothchandar @SteNicholas : Patch is ready to be reviewed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #2111: [HUDI-1234] Insert new records regardless of small file when using insert operation
nsivabalan commented on pull request #2111: URL: https://github.com/apache/hudi/pull/2111#issuecomment-761115228 my bad. had to fix the config naming. do not do line by line review for now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #2111: [HUDI-1234] Insert new records regardless of small file when using insert operation
nsivabalan commented on pull request #2111: URL: https://github.com/apache/hudi/pull/2111#issuecomment-756127108 @vinothchandar : have fixed tests as well. you are good to review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #2111: [HUDI-1234] Insert new records regardless of small file when using insert operation
nsivabalan commented on pull request #2111: URL: https://github.com/apache/hudi/pull/2111#issuecomment-755879362 @vinothchandar : I have updated the patch as requested. Mid way in fixing tests(fixed some and ensured that both old and new code path works as expected though). But in the mean time, if you can review source code, would appreciate. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
