[GitHub] [hudi] nsivabalan commented on pull request #2619: [HUDI-1650] Custom avro kafka deserializer.
nsivabalan commented on pull request #2619: URL: https://github.com/apache/hudi/pull/2619#issuecomment-803175463 @n3nash : addressed the feedback. So, only catch here is that, customer who might use this deserializer, should have ensure their schema provider has one arg constructor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #2619: [HUDI-1650] Custom avro kafka deserializer.
nsivabalan commented on pull request #2619: URL: https://github.com/apache/hudi/pull/2619#issuecomment-802806888 @vburenin : awesome. lets work together and get the patches going. Happy to see Kafka landscape in hudi growing :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #2619: [HUDI-1650] Custom avro kafka deserializer.
nsivabalan commented on pull request #2619: URL: https://github.com/apache/hudi/pull/2619#issuecomment-802279614 @n3nash : patch is ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #2619: [HUDI-1650] Custom avro kafka deserializer.
nsivabalan commented on pull request #2619: URL: https://github.com/apache/hudi/pull/2619#issuecomment-801849186 @vburenin : ok. I will take it up. Whats the other PR for schemaResgistryProvider? I thought only other diff we have is adding Kafka meta fields to every Row within Kafka Source. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #2619: [HUDI-1650] Custom avro kafka deserializer.
nsivabalan commented on pull request #2619: URL: https://github.com/apache/hudi/pull/2619#issuecomment-799507450 @vburenin : Did you get a chance to work on this PR. We would like to have this in before our next release. If you are strapped for time, let me know. I will try to squeeze in sometime this week. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #2619: [HUDI-1650] Custom avro kafka deserializer.
nsivabalan commented on pull request #2619: URL: https://github.com/apache/hudi/pull/2619#issuecomment-794025650 @vburenin : I have added a commit w/ some test set up for AvroKafkaSource. Please feel free to take it up and enhance the tests as per necessity. Ensure you pull in latest commit before you start working on the feedback. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
