[GitHub] [hudi] nsivabalan commented on pull request #2666: [HUDI-1160] Support update partial fields for CoW table

2022-01-23 Thread GitBox


nsivabalan commented on pull request #2666:
URL: https://github.com/apache/hudi/pull/2666#issuecomment-1019551421


   @liujinhui1994 : may I know whats the status on this. Did you put up any 
other patch instead of this one. Wondering why we closed this one ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hudi] nsivabalan commented on pull request #2666: [HUDI-1160] Support update partial fields for CoW table

2021-06-07 Thread GitBox


nsivabalan commented on pull request #2666:
URL: https://github.com/apache/hudi/pull/2666#issuecomment-855848751


   @vinothchandar : my thoughts on adding this payload support for MOR. 
   It may not make sense to add this payload support to MOR. bcoz, in MOR we 
don't lookup previous record values as we only append records to logs. But this 
payload involves fetching previous record and merging with incoming one. So, 
might as well end up using COW for simplicity and since MOR is mainly used to 
shave off some latency during writes. 
   Open to hear your thoughts. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hudi] nsivabalan commented on pull request #2666: [HUDI-1160] Support update partial fields for CoW table

2021-04-01 Thread GitBox


nsivabalan commented on pull request #2666:
URL: https://github.com/apache/hudi/pull/2666#issuecomment-811856279


   @liujinhui1994 : Can you please update the description with an example. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hudi] nsivabalan commented on pull request #2666: [HUDI-1160] Support update partial fields for CoW table

2021-03-15 Thread GitBox


nsivabalan commented on pull request #2666:
URL: https://github.com/apache/hudi/pull/2666#issuecomment-799494981


   @liujinhui1994 : Thanks for the contribution. There are 2 to 3 PRs with 
similar goal. Did you get happen to check out existing ones before putting this 
up? 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org