[GitHub] [hudi] nsivabalan commented on pull request #3921: Revert "[HUDI-2005] Fixing partition path creation in AbstractTableFileSystemView"

2021-12-03 Thread GitBox 


nsivabalan commented on pull request #3921:
URL: https://github.com/apache/hudi/pull/3921#issuecomment-985916164


   Not required anymore since we disabled by default in java.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #3921: Revert "[HUDI-2005] Fixing partition path creation in AbstractTableFileSystemView"

2021-11-05 Thread GitBox 


nsivabalan commented on pull request #3921:
URL: https://github.com/apache/hudi/pull/3921#issuecomment-961908050


   I want to take a stab at this. this is my hunch. 
   We have enabled metadata by default in master, but java does not have 
metadata only. so, will see if we can have diff default values per engine. 
Also, I am not very conversant w/ flink engine as well. so, Please do not land 
this diff. I will investigate on this and will post my updates here.. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #3921: Revert "[HUDI-2005] Fixing partition path creation in AbstractTableFileSystemView"

2021-11-05 Thread GitBox 


nsivabalan commented on pull request #3921:
URL: https://github.com/apache/hudi/pull/3921#issuecomment-961908050


   I want to take a stab at this. this is my hunch. 
   We have enabled metadata by default in master, but java does not have 
metadata only. so, will see if we can have diff default values per engine. 
Also, I am not very conversant w/ flink engine as well. so, Please do not land 
this diff. I will investigate on this and will post my updates here.. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #3921: Revert "[HUDI-2005] Fixing partition path creation in AbstractTableFileSystemView"

2021-11-05 Thread GitBox 


nsivabalan commented on pull request #3921:
URL: https://github.com/apache/hudi/pull/3921#issuecomment-961908050


   I want to take a stab at this. this is my hunch. 
   We have enabled metadata by default in master, but java does not have 
metadata only. so, will see if we can have diff default values per engine. 
Also, I am not very conversant w/ flink engine as well. so, Please do not land 
this diff. I will investigate on this and will post my updates here.. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org