[GitHub] [hudi] prashantwason commented on pull request #1804: [HUDI-960] Implementation of the HFile base and log file format.

2020-08-27 Thread GitBox 


prashantwason commented on pull request #1804:
URL: https://github.com/apache/hudi/pull/1804#issuecomment-682213033


   > @prashantwason if you broadly agree, I will make the change and land this, 
so you can focus on rfc-15 more :)
   Sure @vinothchandar . Thanks for all the help. Lets get this rolling soon.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] prashantwason commented on pull request #1804: [HUDI-960] Implementation of the HFile base and log file format.

2020-07-14 Thread GitBox 


prashantwason commented on pull request #1804:
URL: https://github.com/apache/hudi/pull/1804#issuecomment-658325538


   @vinothchandar Am not currently blocked on this. Take a fine-combed look so 
we can make this a model for adding new file formats to HUDI. 
   
   Please suggest better testing approaches / extra documentation / code 
comments.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org