[GitHub] [hudi] pratyakshsharma commented on a change in pull request #1901: [HUDI-532]Add java doc for hudi test suite test classes

2020-08-06 Thread GitBox 


pratyakshsharma commented on a change in pull request #1901:
URL: https://github.com/apache/hudi/pull/1901#discussion_r466833643



##
File path: 
hudi-integ-test/src/test/java/org/apache/hudi/integ/testsuite/TestDFSHoodieTestSuiteWriterAdapter.java
##
@@ -52,6 +52,9 @@
 import org.junit.jupiter.api.Test;
 import org.mockito.Mockito;
 
+/**
+ * An adapter of {@link HoodieTestSuiteWriter} help to test write DFS file.

Review comment:
   {@link HoodieTestSuiteWriter}. Helps to test writing a DFS file. 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] pratyakshsharma commented on a change in pull request #1901: [HUDI-532]Add java doc for hudi test suite test classes

2020-08-06 Thread GitBox 


pratyakshsharma commented on a change in pull request #1901:
URL: https://github.com/apache/hudi/pull/1901#discussion_r466833116



##
File path: 
hudi-integ-test/src/test/java/org/apache/hudi/integ/testsuite/utils/TestUtils.java
##
@@ -45,6 +48,15 @@
 return dataGenerator.generateGenericRecords(numRecords);
   }
 
+  /**
+   * Method help to create avro files and save it to file.
+   *
+   * @param jsc   {@link JavaSparkContext}.
+   * @param sparkSession  {@link SparkSession}.
+   * @param basePath  The basePath where files written to.

Review comment:
   basePath where files are written. 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] pratyakshsharma commented on a change in pull request #1901: [HUDI-532]Add java doc for hudi test suite test classes

2020-08-06 Thread GitBox 


pratyakshsharma commented on a change in pull request #1901:
URL: https://github.com/apache/hudi/pull/1901#discussion_r466832837



##
File path: 
hudi-integ-test/src/test/java/org/apache/hudi/integ/testsuite/utils/TestUtils.java
##
@@ -28,6 +28,9 @@
 import org.apache.spark.api.java.JavaSparkContext;
 import org.apache.spark.sql.SparkSession;
 
+/**
+ * A utility class for test purpose.

Review comment:
   test -> testing.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] pratyakshsharma commented on a change in pull request #1901: [HUDI-532]Add java doc for hudi test suite test classes

2020-08-06 Thread GitBox 


pratyakshsharma commented on a change in pull request #1901:
URL: https://github.com/apache/hudi/pull/1901#discussion_r466832582



##
File path: 
hudi-integ-test/src/test/java/org/apache/hudi/integ/testsuite/dag/HiveSyncDagGenerator.java
##
@@ -31,6 +31,9 @@
 import org.apache.hudi.integ.testsuite.dag.nodes.HiveSyncNode;
 import org.apache.hudi.integ.testsuite.dag.nodes.InsertNode;
 
+/**
+ * An implementation of {@link WorkflowDagGenerator}, that generate hive sync 
workflowDag.

Review comment:
   ditto.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] pratyakshsharma commented on a change in pull request #1901: [HUDI-532]Add java doc for hudi test suite test classes

2020-08-06 Thread GitBox 


pratyakshsharma commented on a change in pull request #1901:
URL: https://github.com/apache/hudi/pull/1901#discussion_r466832642



##
File path: 
hudi-integ-test/src/test/java/org/apache/hudi/integ/testsuite/dag/HiveSyncDagGeneratorMOR.java
##
@@ -31,6 +31,9 @@
 import org.apache.hudi.integ.testsuite.dag.nodes.HiveSyncNode;
 import org.apache.hudi.integ.testsuite.dag.nodes.InsertNode;
 
+/**
+ * An implementation of {@link WorkflowDagGenerator}, that generate hive sync 
workflowDag for MOR table.

Review comment:
   ditto.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] pratyakshsharma commented on a change in pull request #1901: [HUDI-532]Add java doc for hudi test suite test classes

2020-08-06 Thread GitBox 


pratyakshsharma commented on a change in pull request #1901:
URL: https://github.com/apache/hudi/pull/1901#discussion_r466832530



##
File path: 
hudi-integ-test/src/test/java/org/apache/hudi/integ/testsuite/dag/ComplexDagGenerator.java
##
@@ -33,6 +33,9 @@
 import org.apache.hudi.integ.testsuite.dag.nodes.ValidateNode;
 import org.apache.spark.api.java.JavaRDD;
 
+/**
+ * An implementation of {@link WorkflowDagGenerator}, that generate complex 
workflowDag.

Review comment:
   generate -> generates.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org