[GitHub] [hudi] satishkotha commented on a change in pull request #2129: [HUDI-1302] Add support for timestamp field in HiveSync

[GitBox]

satishkotha commented on a change in pull request #2129:
URL: https://github.com/apache/hudi/pull/2129#discussion_r499747610



##
File path: 
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/util/HiveSchemaUtil.java
##
@@ -167,7 +173,10 @@ private static String convertField(final Type parquetType) 
{
 .append(decimalMetadata.getScale()).append(")").toString();
   } else if (originalType == OriginalType.DATE) {
 return field.append("DATE").toString();
+  } else if (supportTimestamp && originalType == 
OriginalType.TIMESTAMP_MICROS) {

Review comment:
   @n3nash without this change, we get 'bigint' for hive type (goes into 
parquetPrimitiveTypeName.convert -> convertINT64 method)





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] satishkotha commented on a change in pull request #2129: [HUDI-1302] Add support for timestamp field in HiveSync

[GitBox]

satishkotha commented on a change in pull request #2129:
URL: https://github.com/apache/hudi/pull/2129#discussion_r499101046



##
File path: 
hudi-sync/hudi-dla-sync/src/main/java/org/apache/hudi/dla/DLASyncConfig.java
##
@@ -68,6 +68,9 @@
   @Parameter(names = {"--help", "-h"}, help = true)
   public Boolean help = false;
 
+  @Parameter(names = {"--support-timestamp"}, description = "If true, converts 
int64(timestamp_micros) to timestamp type")
+  public Boolean supportTimestamp = false;

Review comment:
   @bschell  thank you for pointing this out. We only use standalone mode, 
so I missed this DataSourceOptions. Fixed now. PTAL.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org