[GitHub] [hudi] satishkotha commented on pull request #2453: [HUDI-1533] Make SerializableSchema work for large schemas

[GitBox]

satishkotha commented on pull request #2453:
URL: https://github.com/apache/hudi/pull/2453#issuecomment-761625093


   > @satishkotha Left some comments, would be good to add a test case by 
keeping a > 64K schema string in a file under resources and use that for a test
   
   @n3nash ok i can try adding large schema test tomorrow. let me know if you 
have any feedback on other comments.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] satishkotha commented on pull request #2453: [HUDI-1533] Make SerializableSchema work for large schemas

[GitBox]

satishkotha commented on pull request #2453:
URL: https://github.com/apache/hudi/pull/2453#issuecomment-761624689


   > Do you think you can add unit tests for this class SerializableSchema.
   
   
https://github.com/apache/hudi/blob/master/hudi-common/src/test/java/org/apache/hudi/common/util/TestSerializableSchema.java
 has already tests. I can add test for large schema



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] satishkotha commented on pull request #2453: [HUDI-1533] Make SerializableSchema work for large schemas

[GitBox]

satishkotha commented on pull request #2453:
URL: https://github.com/apache/hudi/pull/2453#issuecomment-761429551


   @n3nash @vinothchandar This change is contained to clustering and is helpful 
for some usecases. So I'm hoping we can merge before releasing 0.7. PTAL.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org