[GitHub] [hudi] shenh062326 commented on pull request #1690: [HUDI-908] Add decimals to HoodieTestDataGenerator

2020-06-09 Thread GitBox 


shenh062326 commented on pull request #1690:
URL: https://github.com/apache/hudi/pull/1690#issuecomment-641671278


   > @shenh062326 : It makes sense to cover other data-types in a single PR. 
Can you also add them to this PR. Also, Can you let us know what the missing 
data types are ?
   
   The missing spark types:
   ```
   BinaryType
   IntegerType
   LongType
   FloatType
   ByteType
   ShortType
   DecimalType
   TimestampType
   DateType
   ```
   The missing the avro types:
   ```
ENUM,
FIXED,
BYTES,
INT,
LONG,
FLOAT,
NULL
   ```
   But I am not sure if enum and null types are needed.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] shenh062326 commented on pull request #1690: [HUDI-908] Add decimals to HoodieTestDataGenerator

2020-06-09 Thread GitBox 


shenh062326 commented on pull request #1690:
URL: https://github.com/apache/hudi/pull/1690#issuecomment-640978958


   @bvaradar Should I add all data types to this pr or open another pr. My 
original idea was that this pr fixes the bug of parsing decimal type, and 
another pr is added to add other data types



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] shenh062326 commented on pull request #1690: [HUDI-908] Add decimals to HoodieTestDataGenerator

2020-06-02 Thread GitBox 


shenh062326 commented on pull request #1690:
URL: https://github.com/apache/hudi/pull/1690#issuecomment-637961149


   > @shenh062326 I think you might want to resolve the conflicts.
   
   done



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org