[GitHub] [hudi] shenh062326 commented on pull request #2382: [HUDI-1477] Support CopyOnWriteTable in java client

2021-02-12 Thread GitBox 


shenh062326 commented on pull request #2382:
URL: https://github.com/apache/hudi/pull/2382#issuecomment-778149262


   > @shenh062326 Thanks for your contribution, the PR looks good to me. I 
think we would do some refactor between different engine implementation since 
most of the code would be shared, and please file a jira ticket to track.
   
   Add a jira ticket to track, https://issues.apache.org/jira/browse/HUDI-1614



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] shenh062326 commented on pull request #2382: [HUDI-1477] Support CopyOnWriteTable in java client

2021-01-25 Thread GitBox 


shenh062326 commented on pull request #2382:
URL: https://github.com/apache/hudi/pull/2382#issuecomment-767297371


   > @shenh062326 Thanks for your contribution, would you please add some tests 
to verify the java client functionally?
   
   Add TestJavaCopyOnWriteActionExecutor.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] shenh062326 commented on pull request #2382: [HUDI-1477] Support CopyOnWriteTable in java client

2021-01-04 Thread GitBox 


shenh062326 commented on pull request #2382:
URL: https://github.com/apache/hudi/pull/2382#issuecomment-753919104


   > @shenh062326 Thanks for your contribution, would you please add some tests 
to verify the java client functionally?
   
   Sure, I will add a base test infra for java client



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org