[GitHub] [hudi] slfan1989 commented on pull request #8478: [HUDI-6086] Improve HiveSchemaUtil#generateCreateDDL With StringBuilder
slfan1989 commented on PR #8478: URL: https://github.com/apache/hudi/pull/8478#issuecomment-1534233707 I will add a set of unit tests to compare the generated SQL before and after modification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] slfan1989 commented on pull request #8478: [HUDI-6086] Improve HiveSchemaUtil#generateCreateDDL With StringBuilder
slfan1989 commented on PR #8478: URL: https://github.com/apache/hudi/pull/8478#issuecomment-1532800046 > I saw some sub-claused locations are changed, like the `LOCATION` and `CLUSTETERED BY`, is that as expected? @danny0405 Thank you for your thorough review! The modification to the `LOCATION` code should be as expected, but there were some issues with the modification to the `BUCKET` code. I have reverted the `BUCKET` code back to its original state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] slfan1989 commented on pull request #8478: [HUDI-6086] Improve HiveSchemaUtil#generateCreateDDL With StringBuilder
slfan1989 commented on PR #8478: URL: https://github.com/apache/hudi/pull/8478#issuecomment-1532793335 @danny0405 Thank you very much for your reminder! I carefully readed the code again and modify the code. The concatenation order is consistent between the original and modified versions, both of which consist of `7` steps. 1. Append Create Table 2. Append Columns 3. Append Partitions 4. Append Bucket 5. Append Row Format 6. Append Location 7. Append TblProperties > Original Version.  > Modified Version. https://user-images.githubusercontent.com/55643692/235891453-0194117f-7ca3-44f7-b097-e0440f1dc76e.png;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] slfan1989 commented on pull request #8478: [HUDI-6086] Improve HiveSchemaUtil#generateCreateDDL With StringBuilder
slfan1989 commented on PR #8478: URL: https://github.com/apache/hudi/pull/8478#issuecomment-1527394717 @hudi-bot run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] slfan1989 commented on pull request #8478: [HUDI-6086] Improve HiveSchemaUtil#generateCreateDDL With StringBuilder
slfan1989 commented on PR #8478: URL: https://github.com/apache/hudi/pull/8478#issuecomment-1526902500 @danny0405 Thank you very much for helping to review the code and providing suggestions for improvement! I have refactored this part of the code using `StringBuilder`, as we discussed, to improve its readability. I also added some comments to provide additional context and clarification. Sorry for the delayed response. When you have time, could you please review this PR again? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
