[GitHub] [hudi] stayrascal commented on a diff in pull request #7584: [HUDI-5205] Support Flink 1.16.0

2023-01-03 Thread GitBox 


stayrascal commented on code in PR #7584:
URL: https://github.com/apache/hudi/pull/7584#discussion_r1061072974


##
hudi-flink-datasource/hudi-flink1.13.x/src/main/java/org/apache/hudi/adapter/SortCodeGeneratorAdapter.java:
##
@@ -0,0 +1,15 @@
+package org.apache.hudi.adapter;
+
+import org.apache.flink.table.api.TableConfig;
+import org.apache.flink.table.planner.codegen.sort.SortCodeGenerator;
+import org.apache.flink.table.planner.plan.nodes.exec.spec.SortSpec;
+import org.apache.flink.table.types.logical.RowType;
+
+/**
+ * Bridge class for shaded guava clazz {@code SortCodeGenerator}.
+ */

Review Comment:
   got it, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] stayrascal commented on a diff in pull request #7584: [HUDI-5205] Support Flink 1.16.0

2023-01-03 Thread GitBox 


stayrascal commented on code in PR #7584:
URL: https://github.com/apache/hudi/pull/7584#discussion_r1061072838


##
.github/workflows/bot.yml:
##
@@ -95,6 +96,8 @@ jobs:
 strategy:
   matrix:
 include:
+  - flinkProfile: 'flink1.16'
+sparkProfile: 'spark3.3'
   - flinkProfile: 'flink1.15'
 sparkProfile: 'spark3.3'

Review Comment:
   got it.



##
hudi-flink-datasource/hudi-flink1.13.x/src/main/java/org/apache/hudi/adapter/StreamWriteOperatorCoordinatorAdapter.java:
##
@@ -0,0 +1,9 @@
+package org.apache.hudi.adapter;
+
+import org.apache.flink.runtime.operators.coordination.OperatorCoordinator;
+
+/**
+ * Bridge class for shaded guava clazz {@code StreamWriteOperatorCoordinator}.
+ */

Review Comment:
   got it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org