[GitHub] [hudi] stayrascal commented on pull request #7584: [HUDI-5205] Support Flink 1.16.0

2023-01-03 Thread GitBox 


stayrascal commented on PR #7584:
URL: https://github.com/apache/hudi/pull/7584#issuecomment-1370393070

   > @stayrascal @danny0405 Thanks for making this change, just to confirm this 
is targeted for Hudi 0.13.0?
   
   Currently, this change is targeted to master branch(0.13.0), but in my case, 
I will apply this change in old version(0.11.1 or 0.12) once everything passed, 
is there any concern or blockers  about apply this change to older version?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] stayrascal commented on pull request #7584: [HUDI-5205] Support Flink 1.16.0

2023-01-03 Thread GitBox 


stayrascal commented on PR #7584:
URL: https://github.com/apache/hudi/pull/7584#issuecomment-1370391345

   > Thanks for the contribution, I have reviewed and applied a patch here: 
[5205.zip](https://github.com/apache/hudi/files/10334376/5205.zip)
   > 
   > You can apply the patch with cmd: `git apply ${patch_path}` Then force 
push the branch with cmd: `git push ${branch_name} --force`.
   
   Thanks a lot for reviewing this PR, will apply this patch.
   BTW, there are some IT cases failed(NPE) about reading data from 
`ContinousFileSource`, still need fix the issues later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org