[GitHub] [hudi] vingov commented on pull request #3366: [HUDI-1985] Migrate the hudi site to docusaurus platform (website complete re-design)
vingov commented on pull request #3366: URL: https://github.com/apache/hudi/pull/3366#issuecomment-891422776 Thanks for the feedback @vinothchandar! 1. Updated the Next link to Current. 2. Retained the apache links on the footer, but those links are already in the Apache footer menu as well, as far as the [ASF rules](https://www.apache.org/foundation/marks/pmcs#navigation), we should be good without those links as well. 3. Renamed the blog link to "Our Vision" 4. When I checked my local site, the Twitter links were using proper camel casing both on the header and footer, can you please check again? `$ grep -n "twitter.com/ApacheHudi" docusaurus.config.js 176: href: 'https://twitter.com/ApacheHudi', 296: href: 'https://twitter.com/ApacheHudi',` 5. Removed these extra links on resources, to match the current site: - concepts - comparison - migration PTAL! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] vingov commented on pull request #3366: [HUDI-1985] Migrate the hudi site to docusaurus platform (website complete re-design)
vingov commented on pull request #3366: URL: https://github.com/apache/hudi/pull/3366#issuecomment-890669535 @vinothchandar - I have fixed the Travis script as well, similar to the jekyll script, it will build and move it to content folder and it will push it back to asf-site. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] vingov commented on pull request #3366: [HUDI-1985] Migrate the hudi site to docusaurus platform (website complete re-design)
vingov commented on pull request #3366: URL: https://github.com/apache/hudi/pull/3366#issuecomment-890587187 Moreover, for the next version, there is a banner added to let users know that these docs are for the unreleased version: https://user-images.githubusercontent.com/1142498/127785355-e39f3aa4-1011-4259-83a1-9a806e687839.png;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] vingov commented on pull request #3366: [HUDI-1985] Migrate the hudi site to docusaurus platform (website complete re-design)
vingov commented on pull request #3366: URL: https://github.com/apache/hudi/pull/3366#issuecomment-890585823 Thanks for the review @nsivabalan! 1. Updated the roadmap link to streaming data lake's latest blog link. 2. The "Next" link shows the latest master branch docs, Next meaning the next unreleased version docs, it's not selected by default, only the latest stable release docs are shown by default, the next version is easier for developers to validate their docs changes. - There is a flag to hide the next link, if you still prefer to hide it, let me know I can disable it. 3. Added Robinhood to the powered-by page. 4. Yes, we can make use of the tabs to separate out the spark/flink configs, I see that there are few changes already in the latest unreleased version, we can take that later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] vingov commented on pull request #3366: [HUDI-1985] Migrate the hudi site to docusaurus platform (website complete re-design)
vingov commented on pull request #3366:
URL: https://github.com/apache/hudi/pull/3366#issuecomment-890382200
Summary of changes:
1. Docusaurus doesn't have the concept of permalink in the header, the URL
is formed based on the folder and file name, hence renamed all the files with
the permalink to preserve the old path and to avoid broken links for the docs.
2. Since the new navigation structure is different for the non-doc static
pages, I've updated all the references in the document.
3. Docusaurus doesn't support a few of the Jekyll features like:
- The HTML class attribute should be called className, hence updated those.
- In some cases, the tag messes up the formatting of the content
hence got rid of it.
- Fixed the broken HTML tags.
- For loops got converted to a theme component for the powered-by page.
- Keywords should be an array instead of a comma-separated string.
4. Rebuilt the left sidebar and all old docs version sidebar and the main
dropdown navigation.
5. Moved around a bunch of files and renamed some to support versioning and
i18n support.
6. Most of the classic theme looked good already out of the box, fixed a
bunch of them in the src/css/custom.css.
7. Rebuild the home page as a pure js rendered page src/pages/index.js.
8. Built the footer navigation with all relevant links to improve the SEO
and ease of use and improve the visibility of the inner pages.
9. Broken the releases page to individual pages, to improve the usability
and to support the left side bar.
10. Broken the community page into 3 pages:
- Get Involved.
- Team.
- How to Contribute
11. Added the code tab support for the quick-start spark guide, the same
could be easily applied for other pages.
Please refer to the [docusaurus official documentation
](https://docusaurus.io/docs/markdown-features)for adding more features to the
site.
This is not the final version, the first step in the process is to migrate
the content as-is with few minor changes to the docusaurus platform, then we
can make incremental changes to add more features.
I'll be adding the search bar in the next iteration.
These sed one-liners saved the day for me!!
```
sed -i '' -E 's/src=("[^"]*")/src={require(\1).default}/g' *.md
sed -i '' -E 's/keywords:(.*)$/keywords: [\1]/g' *.md
sed -i '' -E 's///g' *.md
sed -i '' -E 's/style=("[^"]*")//g' *.md
sed -i '' -E 's/class=("[^"]*")/className=\1/g' *.md
sed -i '' -E 's|/docs/0.5.0-|/docs/|g' *.md
sed -i '' -E 's|/docs/0.5.1-|/docs/|g' *.md
sed -i '' -E 's|/docs/0.5.2-|/docs/|g' *.md
sed -i '' -E 's|/docs/0.5.3-|/docs/|g' *.md
sed -i '' -E 's|/docs/0.6.0-|/docs/|g' *.md
sed -i '' -E 's|/docs/0.7.0-|/docs/|g' *.md
sed -i '' -E 's|/docs/0.8.0-|/docs/|g' *.md
find . -name '*.md' -exec sed -i '' '/permalink:/d' {} +
for filename in *.cn.md; do mv $filename ${filename//cn.md/md}; done
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hudi] vingov commented on pull request #3366: [HUDI-1985] Migrate the hudi site to docusaurus platform (website complete re-design)
vingov commented on pull request #3366: URL: https://github.com/apache/hudi/pull/3366#issuecomment-890272138 @nsivabalan - Can you please review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] vingov commented on pull request #3366: [HUDI-1985] Migrate the hudi site to docusaurus platform (website complete re-design)
vingov commented on pull request #3366: URL: https://github.com/apache/hudi/pull/3366#issuecomment-889591087 > @vingov @nsivabalan Shall we move the schema evolution subsection to a new page under documentation? It's gonna be a story of its own. Yes, we can do all structural changes after we land this version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] vingov commented on pull request #3366: [HUDI-1985] Migrate the hudi site to docusaurus platform (website complete re-design)
vingov commented on pull request #3366: URL: https://github.com/apache/hudi/pull/3366#issuecomment-889509332 Created a [short demo](https://www.awesomescreenshot.com/video/4661736?key=12a221a8a04e097a99200c061d32ca27) of the new site re-design with docusarus platform to make it easy for the reviewers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
