[GitHub] [hudi] vinothchandar commented on pull request #1810: [HUDI-875] Abstract hudi-sync-common, and support hudi-hive-sync

2020-08-05 Thread GitBox


vinothchandar commented on pull request #1810:
URL: https://github.com/apache/hudi/pull/1810#issuecomment-669238039


   @lw309637554  this seems ready?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hudi] vinothchandar commented on pull request #1810: [HUDI-875] Abstract hudi-sync-common, and support hudi-hive-sync

2020-08-04 Thread GitBox


vinothchandar commented on pull request #1810:
URL: https://github.com/apache/hudi/pull/1810#issuecomment-668974757


   @lw309637554 is this ready for a final review? 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hudi] vinothchandar commented on pull request #1810: [HUDI-875] Abstract hudi-sync-common, and support hudi-hive-sync

2020-08-03 Thread GitBox


vinothchandar commented on pull request #1810:
URL: https://github.com/apache/hudi/pull/1810#issuecomment-668392214


   @lw309637554 I rebased this off master and also did some of the smaller 
stuff myself. if we can make a call on the multiple targets and the metrics 
questions, we can can resolve and land 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hudi] vinothchandar commented on pull request #1810: [HUDI-875] Abstract hudi-sync-common, and support hudi-hive-sync

2020-08-03 Thread GitBox


vinothchandar commented on pull request #1810:
URL: https://github.com/apache/hudi/pull/1810#issuecomment-668367172


   > IMO, that will be great if we can remove the hive dependency from 
hudi-spark and hudi-utilities 
   
   We can discuss on the JIRA. but this needs more thought. We want spark 
datasource write and deltastreamer to continue to sync to hive, when the write 
completes. So, its a necessary thing IMO



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hudi] vinothchandar commented on pull request #1810: [HUDI-875] Abstract hudi-sync-common, and support hudi-hive-sync

2020-08-02 Thread GitBox


vinothchandar commented on pull request #1810:
URL: https://github.com/apache/hudi/pull/1810#issuecomment-667785088


   This is on my plate for this week.  



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hudi] vinothchandar commented on pull request #1810: [HUDI-875] Abstract hudi-sync-common, and support hudi-hive-sync

2020-07-22 Thread GitBox


vinothchandar commented on pull request #1810:
URL: https://github.com/apache/hudi/pull/1810#issuecomment-662830316


   @lw309637554 can you please give me a couple days. I am trying to prioritize 
all the 0.6.0 blockers for now. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org