[GitHub] [hudi] vinothchandar commented on pull request #2033: [HUDI-1222] Introduce MergeHelper.UpdateHandler as independent class

2020-09-01 Thread GitBox 


vinothchandar commented on pull request #2033:
URL: https://github.com/apache/hudi/pull/2033#issuecomment-684886431


   that refactor is going to be huge anyway. if you are making code changes and 
moving the files around, its better to do in a separate PR. otherwise, if its 
all file moves. we can do it in one pr 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] vinothchandar commented on pull request #2033: [HUDI-1222] Introduce MergeHelper.UpdateHandler as independent class

2020-08-25 Thread GitBox 


vinothchandar commented on pull request #2033:
URL: https://github.com/apache/hudi/pull/2033#issuecomment-679965694


   for such a helper struct like class, it makes sense to be inline right? can 
you please help me understand the reason behind this refactor. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org