[GitHub] [hudi] wangxianghu commented on pull request #2337: [HUDI-982] Flink support mor table

2021-02-28 Thread GitBox 


wangxianghu commented on pull request #2337:
URL: https://github.com/apache/hudi/pull/2337#issuecomment-787657819


   @liujinhui1994 It seems this pr is fixed by 
https://github.com/apache/hudi/commit/7a11de12764d8f68f296c6e68a22822318bfbefa ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] wangxianghu commented on pull request #2337: [HUDI-982] Flink support mor table

2020-12-16 Thread GitBox 


wangxianghu commented on pull request #2337:
URL: https://github.com/apache/hudi/pull/2337#issuecomment-747267314


   hi @liujinhui1994 thanks for your contributions
   Since flink related test suite is under development, it's hard to decide 
whether your pr is ok.
   Do you mind testing it in your cluster env firstly to give us more 
confidence, then, we can continue the review .
   WDYT?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] wangxianghu commented on pull request #2337: [HUDI-982] Flink support mor table

2020-12-16 Thread GitBox 


wangxianghu commented on pull request #2337:
URL: https://github.com/apache/hudi/pull/2337#issuecomment-745890937


   > @wangxianghu Would you please review this pr firstly?
   
   ack will review soon



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org