[GitHub] [hudi] wangxianghu removed a comment on pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-10-01 Thread GitBox 


wangxianghu removed a comment on pull request #1827:
URL: https://github.com/apache/hudi/pull/1827#issuecomment-702217863


   > @leesf do you see the following exception? could not understand how you ll 
get the other one even.
   > 
   > ```
   > LOG.info("Starting Timeline service !!");
   > Option hostAddr = 
context.getProperty(EngineProperty.EMBEDDED_SERVER_HOST);
   > if (!hostAddr.isPresent()) {
   >   throw new HoodieException("Unable to find host address to bind 
timeline server to.");
   > }
   > timelineServer = Option.of(new EmbeddedTimelineService(context, 
hostAddr.get(),
   > config.getClientSpecifiedViewStorageConfig()));
   > ```
   > 
   > Either way, good pointer. the behavior has changed around this a bit 
actually. So will try and tweak and push a fix
   
   I got this warning too. The code here seems not the same.
   ```
// Run Embedded Timeline Server
   LOG.info("Starting Timeline service !!");
   Option hostAddr = 
context.getProperty(EngineProperty.EMBEDDED_SERVER_HOST);
   timelineServer = Option.of(new EmbeddedTimelineService(context, 
hostAddr.orElse(null),
   config.getClientSpecifiedViewStorageConfig()));
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] wangxianghu removed a comment on pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-10 Thread GitBox 


wangxianghu removed a comment on pull request #1827:
URL: https://github.com/apache/hudi/pull/1827#issuecomment-689916910


   > @wangxianghu the issue with the tests is that, now most of the tests are 
moved to hudi-spark-client. previously we had split tests into hudi-client and 
others. We need to edit `travis.yml` to adjust the splits again
   
   @vinothchandar could you please help me edit travis.yml to adjust the splits 
.. I am not familiar with that
   thanks :)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org