[GitHub] [hudi] xushiyan commented on a diff in pull request #9324: [HUDI-6619] [WIP] Fix hudi-integ-test-bundle dependency on jackson jsk310 package.

2023-08-03 Thread via GitHub 


xushiyan commented on code in PR #9324:
URL: https://github.com/apache/hudi/pull/9324#discussion_r1283702886


##
pom.xml:
##
@@ -98,8 +98,6 @@
 
${fasterxml.spark3.version}
 
${fasterxml.spark3.version}
 
${fasterxml.spark3.version}
-
-

Review Comment:
   as this variable is removed, can you global search and make sure all refs 
are updated?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] xushiyan commented on a diff in pull request #9324: [HUDI-6619] [WIP] Fix hudi-integ-test-bundle dependency on jackson jsk310 package.

2023-08-02 Thread via GitHub 


xushiyan commented on code in PR #9324:
URL: https://github.com/apache/hudi/pull/9324#discussion_r1281444222


##
pom.xml:
##
@@ -98,8 +98,6 @@
 
${fasterxml.spark3.version}
 
${fasterxml.spark3.version}
 
${fasterxml.spark3.version}
-
-

Review Comment:
   > this special treatement for JSR310 package was needed
   
   can you help clarify why? the intention was to avoid duplicated bundling of 
this module.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org