[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #935: [HUDI-287] Remove LICENSE and NOTICE files in hoodie child modules.
bvaradar commented on a change in pull request #935: [HUDI-287] Remove LICENSE and NOTICE files in hoodie child modules. URL: https://github.com/apache/incubator-hudi/pull/935#discussion_r330874769 ## File path: pom.xml ## @@ -166,9 +104,9 @@ -scm:git:g...@github.com:apache/incubator-hudi.git - scm:git:g...@github.com:apache/incubator-hudi.git -g...@github.com:apache/incubator-hudi.git + scm:git:https://gitbox.apache.org/repos/asf/incubator-hudi.git Review comment: @tweise: Reverted this change. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #935: [HUDI-287] Remove LICENSE and NOTICE files in hoodie child modules.
bvaradar commented on a change in pull request #935: [HUDI-287] Remove LICENSE and NOTICE files in hoodie child modules. URL: https://github.com/apache/incubator-hudi/pull/935#discussion_r330868161 ## File path: pom.xml ## @@ -166,9 +104,9 @@ -scm:git:g...@github.com:apache/incubator-hudi.git - scm:git:g...@github.com:apache/incubator-hudi.git -g...@github.com:apache/incubator-hudi.git + scm:git:https://gitbox.apache.org/repos/asf/incubator-hudi.git Review comment: @tweise : To be compliant for the voting process, I looked into how the parent pom (apache-21.pom) is setup. The corresponding codebase for apache-21.pom is in github but they had similar setup : https://github.com/apache/maven-apache-parent/blob/master/pom.xml . I was not aware of the implication of this change. I am happy to revert the scm configuration as we want developers to use github. Will update the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #935: [HUDI-287] Remove LICENSE and NOTICE files in hoodie child modules.
bvaradar commented on a change in pull request #935: [HUDI-287] Remove LICENSE and NOTICE files in hoodie child modules. URL: https://github.com/apache/incubator-hudi/pull/935#discussion_r330746584 ## File path: pom.xml ## @@ -67,67 +67,8 @@ https://www.apache.org - - - vinothchandar - Vinoth Chandar - Confluent Inc - - - prasannarajaperumal - Prasanna Rajaperumal - Snowflake - - - n3nash - Nishith Agarwal - Uber - - - bvaradar - Balaji Varadharajan - Uber - - - - - - Wei Yan - Uber - - - Siddhartha Gunda - Uber - - - Omkar Joshi - Uber - - - Zeeshan Qureshi - Shopify - - - Kathy Ge - Shopify - - - Kaushik Devarajaiah - Uber - - - Anbu Cheeralan - DoubleVerify - - - Jiale Tan - Vungle - - - 2016 Review comment: @vinothchandar : Took a look at the parent apache pom (https://github.com/apache/maven-apache-parent/blob/apache-21/pom.xml) and made changes accordingly to hoodie parent pom This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #935: [HUDI-287] Remove LICENSE and NOTICE files in hoodie child modules.
bvaradar commented on a change in pull request #935: [HUDI-287] Remove LICENSE and NOTICE files in hoodie child modules. URL: https://github.com/apache/incubator-hudi/pull/935#discussion_r330738298 ## File path: pom.xml ## @@ -67,67 +67,8 @@ https://www.apache.org - - - vinothchandar - Vinoth Chandar - Confluent Inc - - - prasannarajaperumal - Prasanna Rajaperumal - Snowflake - - - n3nash - Nishith Agarwal - Uber - - - bvaradar - Balaji Varadharajan - Uber - - - - - - Wei Yan - Uber - - - Siddhartha Gunda - Uber - - - Omkar Joshi - Uber - - - Zeeshan Qureshi - Shopify - - - Kathy Ge - Shopify - - - Kaushik Devarajaiah - Uber - - - Anbu Cheeralan - DoubleVerify - - - Jiale Tan - Vungle - - - 2016 Review comment: Will make a pass for others This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #935: [HUDI-287] Remove LICENSE and NOTICE files in hoodie child modules.
bvaradar commented on a change in pull request #935: [HUDI-287] Remove LICENSE and NOTICE files in hoodie child modules. URL: https://github.com/apache/incubator-hudi/pull/935#discussion_r330735638 ## File path: pom.xml ## @@ -67,67 +67,8 @@ https://www.apache.org - - - vinothchandar - Vinoth Chandar - Confluent Inc - - - prasannarajaperumal - Prasanna Rajaperumal - Snowflake - - - n3nash - Nishith Agarwal - Uber - - - bvaradar - Balaji Varadharajan - Uber - - - - - - Wei Yan - Uber - - - Siddhartha Gunda - Uber - - - Omkar Joshi - Uber - - - Zeeshan Qureshi - Shopify - - - Kathy Ge - Shopify - - - Kaushik Devarajaiah - Uber - - - Anbu Cheeralan - DoubleVerify - - - Jiale Tan - Vungle - - - 2016 Review comment: @vinothchandar : Saw this in flink https://github.com/apache/flink/blob/master/pom.xml#L36. thats why left it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
