[GitHub] [incubator-hudi] lamber-ken commented on issue #1351: [WIP] [HUDI-625] Fixing performance issues around DiskBasedMap & kryo
lamber-ken commented on issue #1351: [WIP] [HUDI-625] Fixing performance issues around DiskBasedMap & kryo URL: https://github.com/apache/incubator-hudi/pull/1351#issuecomment-590634434 > response -> the StdInstantiatorStrategy will allow kryo to fall back to Java Serde, is that what we want ? Hi @n3nash, By default, an instantiator is returned that uses reflection if the class has a zero argument constructor, an exception is thrown. If a `setInstantiatorStrategy(InstantiatorStrategy)` is set, it will be used instead of throwing an exception. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1351: [WIP] [HUDI-625] Fixing performance issues around DiskBasedMap & kryo
lamber-ken commented on issue #1351: [WIP] [HUDI-625] Fixing performance issues around DiskBasedMap & kryo URL: https://github.com/apache/incubator-hudi/pull/1351#issuecomment-590618074 Thanks @vinothchandar, had opend a new pr https://github.com/apache/incubator-hudi/pull/1352 : ) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1351: [WIP] [HUDI-625] Fixing performance issues around DiskBasedMap & kryo
lamber-ken commented on issue #1351: [WIP] [HUDI-625] Fixing performance issues around DiskBasedMap & kryo URL: https://github.com/apache/incubator-hudi/pull/1351#issuecomment-590506849 Hi @n3nash, we talked about this issue in [HUDI-625](https://issues.apache.org/jira/browse/HUDI-625) . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1351: [WIP] [HUDI-625] Fixing performance issues around DiskBasedMap & kryo
lamber-ken commented on issue #1351: [WIP] [HUDI-625] Fixing performance issues around DiskBasedMap & kryo URL: https://github.com/apache/incubator-hudi/pull/1351#issuecomment-590142768 Because we already set InstantiatorStrategy, so we needn't register class agian. `kryo.setInstantiatorStrategy(new org.objenesis.strategy.StdInstantiatorStrategy());` Change `Kryo kryo = new KryoBase();` to `Kryo kryo = new Kryo();` will ok. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
