[GitHub] [incubator-hudi] leesf commented on issue #928: [HUDI-265] Failed to delete tmp dirs created in unit tests

2019-10-03 Thread GitBox 
leesf commented on issue #928: [HUDI-265] Failed to delete tmp dirs created in 
unit tests
URL: https://github.com/apache/incubator-hudi/pull/928#issuecomment-537838407
 
 
   Any other concerns to be merged? @vinothchandar 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] leesf commented on issue #928: [HUDI-265] Failed to delete tmp dirs created in unit tests

2019-10-02 Thread GitBox 
leesf commented on issue #928: [HUDI-265] Failed to delete tmp dirs created in 
unit tests
URL: https://github.com/apache/incubator-hudi/pull/928#issuecomment-537423776
 
 
   @vinothchandar Updated the PR to address the comments.
   
   _1. Introduce HoodieCommonTestHarness.
   2. Make HoodieClientTestHarness extends HoodieCommonTestHarness and move 
getTableType to HoodieCommonTestHarness. 
   3. Make some UTs in common module extend HoodieCommonTestHarness._
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services