[GitHub] [incubator-hudi] vinothchandar commented on issue #1105: [WIP] [HUDI-405] Fix sync no hive partition at first time
vinothchandar commented on issue #1105: [WIP] [HUDI-405] Fix sync no hive partition at first time URL: https://github.com/apache/incubator-hudi/pull/1105#issuecomment-570112392 @lamber-ken can you fix the PR title.. I am going to ask @bvaradar to take a quick look and confirm dropping this is fine at uber.. and after these two we can merge This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on issue #1105: [WIP] [HUDI-405] Fix sync no hive partition at first time
vinothchandar commented on issue #1105: [WIP] [HUDI-405] Fix sync no hive
partition at first time
URL: https://github.com/apache/incubator-hudi/pull/1105#issuecomment-57005
>option("hoodie.datasource.hive_sync.assume_date_partitioning", true).
We don't expect this to be set by anyone except Uber.. `false` has been the
default ever since.. So I think the right thing may be is to remove this config
from DataSource if thats what causes this issue.. We should still keep this on
the WriteClient level.
http://hudi.apache.org/configurations.html#withAssumeDatePartitioning clearly
calls out the version requirements..
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on issue #1105: [WIP] [HUDI-405] Fix sync no hive partition at first time
vinothchandar commented on issue #1105: [WIP] [HUDI-405] Fix sync no hive partition at first time URL: https://github.com/apache/incubator-hudi/pull/1105#issuecomment-569980467 >So, modify assumeDatePartitioning to ! assumeDatePartitioning is the best way to fix this issue. This is not going to fix this issue.. and we should not be changing this code.. It will cause side effects, like I mentioned before. Can we reproduce this issue in a unit test or sample code first? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on issue #1105: [WIP] [HUDI-405] Fix sync no hive partition at first time
vinothchandar commented on issue #1105: [WIP] [HUDI-405] Fix sync no hive partition at first time URL: https://github.com/apache/incubator-hudi/pull/1105#issuecomment-569971619 @lamber-ken I still don't fully understand the need for this fix.. Can you please summarize where we are? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
