[GitHub] [incubator-hudi] vinothchandar commented on issue #1159: [WIP][HUDI-479] Eliminate or Minimize use of Guava if possible

2020-01-26 Thread GitBox
vinothchandar commented on issue #1159: [WIP][HUDI-479] Eliminate or Minimize 
use of Guava if possible
URL: https://github.com/apache/incubator-hudi/pull/1159#issuecomment-578479958
 
 
   @smarthi when you reach the bottom of the barrel, can we also add a rule 
here to disallow guava?
   
   
https://github.com/apache/incubator-hudi/blob/master/style/checkstyle.xml#L266 
   
   I can then do a final review and merge.. (Looks like there is one clean up 
pending before this one) 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-hudi] vinothchandar commented on issue #1159: [WIP][HUDI-479] Eliminate or Minimize use of Guava if possible

2020-01-18 Thread GitBox
vinothchandar commented on issue #1159: [WIP][HUDI-479] Eliminate or Minimize 
use of Guava if possible
URL: https://github.com/apache/incubator-hudi/pull/1159#issuecomment-575921472
 
 
   May need to rebase. Will do a full review post code freeze.. Trying to 
minimize large changes at last min 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services