[GitHub] [incubator-hudi] xushiyan commented on a change in pull request #1640: [MINOR] Fix resource cleanup in TestTableSchemaEvolution

2020-05-20 Thread GitBox 


xushiyan commented on a change in pull request #1640:
URL: https://github.com/apache/incubator-hudi/pull/1640#discussion_r428110614



##
File path: pom.xml
##
@@ -245,7 +245,8 @@
 ${maven-surefire-plugin.version}
 
   ${skipUTs}
-  -Xms256m -Xmx2g
+  -Xmx2g

Review comment:
   @vinothchandar noted. I'll make sure message is self-explanatory onwards.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-hudi] xushiyan commented on a change in pull request #1640: [MINOR] Fix resource cleanup in TestTableSchemaEvolution

2020-05-19 Thread GitBox 


xushiyan commented on a change in pull request #1640:
URL: https://github.com/apache/incubator-hudi/pull/1640#discussion_r427746163



##
File path: pom.xml
##
@@ -245,7 +245,8 @@
 ${maven-surefire-plugin.version}
 
   ${skipUTs}
-  -Xms256m -Xmx2g
+  -Xmx2g

Review comment:
   Trying to improve the config as well...thinking -Xms it is not needed. 
And below this line, extending process exit timeout from 30 to 120 sec should 
be safe to do. I can also revert the `pom.xml` if you prefer separate the 
changes from this PR.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org