[GitHub] [incubator-hudi] xushiyan commented on issue #1360: [HUDI-344][RFC-09] Hudi Dataset Snapshot Exporter
xushiyan commented on issue #1360: [HUDI-344][RFC-09] Hudi Dataset Snapshot Exporter URL: https://github.com/apache/incubator-hudi/pull/1360#issuecomment-596201573 @OpenOpened To summarize from the review comments, could you make these changes as last round of changes? thanks 1. remove `--snapshot-prefix` 2. remove `@deprecated` from javadoc 3. add `@experimental` to the new class javadoc This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] xushiyan commented on issue #1360: [HUDI-344][RFC-09] Hudi Dataset Snapshot Exporter
xushiyan commented on issue #1360: [HUDI-344][RFC-09] Hudi Dataset Snapshot Exporter URL: https://github.com/apache/incubator-hudi/pull/1360#issuecomment-595927116 > @xushiyan could you please make one pass and resolve the comments that are already addressed.. @vinothchandar I'm not able to resolve comments, the "resolve" buttons are not shown to me. guess it's due to permission :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] xushiyan commented on issue #1360: [HUDI-344][RFC-09] Hudi Dataset Snapshot Exporter
xushiyan commented on issue #1360: [HUDI-344][RFC-09] Hudi Dataset Snapshot Exporter URL: https://github.com/apache/incubator-hudi/pull/1360#issuecomment-593753301 @OpenOpened Thanks for the changes. I saw there are issues with existing Copier tests which need some further refactoring and fixing. I'd like to set a realistic criteria for merging this PR: as we don't have to make the utility perfect in the first round so I'd give +1 as long as the functionality works in a basic manner: output can be generated, no worry in perf and fully covered in unit tests. In addition, putting an `@experimental` in the class docs and do not `@deprecate` the original Copier. Please kindly share your input. @leesf @vinothchandar thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] xushiyan commented on issue #1360: [HUDI-344][RFC-09] Hudi Dataset Snapshot Exporter
xushiyan commented on issue #1360: [HUDI-344][RFC-09] Hudi Dataset Snapshot Exporter URL: https://github.com/apache/incubator-hudi/pull/1360#issuecomment-592062005 > @xushiyan please review this pr. Sure, will look at this by this week. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
