[GitHub] [incubator-hudi] xushiyan commented on pull request #1572: [HUDI-836] Implement datadog metrics reporter
xushiyan commented on pull request #1572: URL: https://github.com/apache/incubator-hudi/pull/1572#issuecomment-632789214 > @xushiyan may be we need to doc this or write a small post? Yes @vinothchandar will do the post soon. Config docs update is in #1603 . As for http-client, I have been using this implementation in production, looking good so far. Will definitely test it with more scenarios. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-hudi] xushiyan commented on pull request #1572: [HUDI-836] Implement datadog metrics reporter
xushiyan commented on pull request #1572: URL: https://github.com/apache/incubator-hudi/pull/1572#issuecomment-629702325 @yanghua CI passed. Also updated #1603 for the newly added config. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-hudi] xushiyan commented on pull request #1572: [HUDI-836] Implement datadog metrics reporter
xushiyan commented on pull request #1572: URL: https://github.com/apache/incubator-hudi/pull/1572#issuecomment-628304476 Note: blocked by #1623 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-hudi] xushiyan commented on pull request #1572: [HUDI-836] Implement datadog metrics reporter
xushiyan commented on pull request #1572: URL: https://github.com/apache/incubator-hudi/pull/1572#issuecomment-626460368 @yanghua In the last commit, I added a new config class `HoodieMetricsDatadogConfig` just for datadog related configs and reverted previous change to `HoodieMetricsConfig`. I think it'd be better to refactor the configs of 2 other reporter types in a separate PR to minimize risks. If the new config class looks good, I'll do a separate PR for the other two, probably with some test cases, too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-hudi] xushiyan commented on pull request #1572: [HUDI-836] Implement datadog metrics reporter
xushiyan commented on pull request #1572: URL: https://github.com/apache/incubator-hudi/pull/1572#issuecomment-625661496 @yanghua Once this is approved, I'll then update this docs update PR https://github.com/apache/incubator-hudi/pull/1603 with Chinese version. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-hudi] xushiyan commented on pull request #1572: [HUDI-836] Implement datadog metrics reporter
xushiyan commented on pull request #1572: URL: https://github.com/apache/incubator-hudi/pull/1572#issuecomment-625360473 @vinothchandar @yanghua CI is passing now... I don't seem to have tests failing; it seemed just sometimes travis got freaked out... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-hudi] xushiyan commented on pull request #1572: [HUDI-836] Implement datadog metrics reporter
xushiyan commented on pull request #1572: URL: https://github.com/apache/incubator-hudi/pull/1572#issuecomment-624831618 @yanghua @vinothchandar The travis tests is flaky; i can pass the tests locally. Please go ahead review the PR; I'll do some checkings on the CI failure later. Thank you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-hudi] xushiyan commented on pull request #1572: [HUDI-836] Implement datadog metrics reporter
xushiyan commented on pull request #1572: URL: https://github.com/apache/incubator-hudi/pull/1572#issuecomment-624435108 Just observed weird CI failure...first time seeing OOM there. Trying with some settings in https://github.com/apache/incubator-hudi/pull/1595 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-hudi] xushiyan commented on pull request #1572: [HUDI-836] Implement datadog metrics reporter
xushiyan commented on pull request #1572: URL: https://github.com/apache/incubator-hudi/pull/1572#issuecomment-624415349 @yanghua Right. I'll make another PR to update the configs docs, too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-hudi] xushiyan commented on pull request #1572: [HUDI-836] Implement datadog metrics reporter
xushiyan commented on pull request #1572: URL: https://github.com/apache/incubator-hudi/pull/1572#issuecomment-624372155 @vinothchandar I'm thinking of writing another short blog to introduce Datadog support with the new configs. Sounds good? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-hudi] xushiyan commented on pull request #1572: [HUDI-836] Implement datadog metrics reporter
xushiyan commented on pull request #1572: URL: https://github.com/apache/incubator-hudi/pull/1572#issuecomment-624370686 @yanghua This is ready for review. Also manually tested the implementation and was able to collect metrics in Datadog.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
