Re: [I] [DISCUSSION] Deltastreamer - Reading commit checkpoint from Kafka instead of latest Hoodie commit [hudi]

2024-06-03 Thread via GitHub


KishanFairmatic commented on issue #11268:
URL: https://github.com/apache/hudi/issues/11268#issuecomment-2145507599

   @danny0405 : In master i.e. HUDI version 1.0.0, there is a flag 
`--ignore-checkpoint`, which will do the same thing. We use version 0.13.0 for 
now, so would use this for now till 1.0.0 is stable and we are ready to 
upgrade. 
   
   But by default, when auto.offset.reset = group, and for the first attempt 
when there are no commits in kafka, it defaults to latest, which might mean 
loss of data. Either that should be earliest, or there should be an option to 
choose earliest to prevent missing any data. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [DISCUSSION] Deltastreamer - Reading commit checkpoint from Kafka instead of latest Hoodie commit [hudi]

2024-06-03 Thread via GitHub


danny0405 commented on issue #11268:
URL: https://github.com/apache/hudi/issues/11268#issuecomment-2144599040

   Ususally we do not creating PR agains released tag, can you fire a new one 
against master?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [DISCUSSION] Deltastreamer - Reading commit checkpoint from Kafka instead of latest Hoodie commit [hudi]

2024-06-03 Thread via GitHub


KishanFairmatic commented on issue #11268:
URL: https://github.com/apache/hudi/issues/11268#issuecomment-2144428066

   @danny0405 : We made changes to hudi, and will be using the code internally. 
The following PR embodies the proposed changes. Any thoughts or inputs? Will be 
happy to work more on getting this PR merged to hudi.
   
   https://github.com/apache/hudi/pull/11383


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [DISCUSSION] Deltastreamer - Reading commit checkpoint from Kafka instead of latest Hoodie commit [hudi]

2024-05-22 Thread via GitHub


danny0405 commented on issue #11268:
URL: https://github.com/apache/hudi/issues/11268#issuecomment-2125996412

   > We reviewed the deltastreamer code and noticed that the deltastreamer can 
read commits from Kafka consumer groups
   
   If the consumer `offset` is what the Hoodie checkpoint persisted, sounds 
more reasonable to always pull the offset from the Kafka server where the 
offset can be managed in good shape.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] [DISCUSSION] Deltastreamer - Reading commit checkpoint from Kafka instead of latest Hoodie commit [hudi]

2024-05-22 Thread via GitHub


KishanFairmatic opened a new issue, #11268:
URL: https://github.com/apache/hudi/issues/11268

   
   Our requirement is actually this: Supporting multiple deltastreamers writing 
to a single hudi table
   
   
[https://github.com/apache/hudi/issues/6718](https://github.com/apache/hudi/issues/6718)
   [HUDI-5077](https://issues.apache.org/jira/browse/HUDI-5077)
   
   We reviewed the deltastreamer code and noticed that the deltastreamer can 
read commits from Kafka consumer groups if it doesn't find the last checkpoint 
from Hoodie.
   
   We're considering modifying the code to always read commits from Kafka, 
based on a new flag, by making changes in the Hudi deltastreamer.
   
   Do you foresee any nuances or issues with this approach?
   
   **Environment Description**
   
   * Hudi version : 0.13.0
   
   * Spark version : 3.3.2
   
   * Storage (HDFS/S3/GCS..) : S3
   
   * Running on Docker? (yes/no) : no
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org