Re: [I] [SUPPORT] Bulk insert does not handle hoodie metrics [hudi]

2023-12-23 Thread via GitHub


parisni commented on issue #10395:
URL: https://github.com/apache/hudi/issues/10395#issuecomment-1868406313

   so I did take a look into the code, and I don't see reason why bulk-insert 
operation would not report metrics. As other operation it goes into that path 
https://github.com/apache/hudi/blob/c2da8aaa5fadb1b3984f6fde2a034c806b501fc5/hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DefaultSource.scala#L146
   which among all reports the metrics 
https://github.com/apache/hudi/blob/c2da8aaa5fadb1b3984f6fde2a034c806b501fc5/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/Metrics.java#L118
   
   I also can confirm when I set `hoodie.metrics.reporter.type=CONSOLE` 
,bulk_insert logs the metrics.
   The problem comes when using datadog as a reporter, it works fine with any 
operation except bulk_insert.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [SUPPORT] Bulk insert does not handle hoodie metrics [hudi]

2023-12-22 Thread via GitHub


parisni commented on issue #10395:
URL: https://github.com/apache/hudi/issues/10395#issuecomment-1867390194

   Yes I can work on this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [SUPPORT] Bulk insert does not handle hoodie metrics [hudi]

2023-12-21 Thread via GitHub


danny0405 commented on issue #10395:
URL: https://github.com/apache/hudi/issues/10395#issuecomment-1867155072

   Hmm, would you mind to add some metrics.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org