Re: [PR] [HUDI-7131] Fixing schema used to read base file in HoodieMergedReadHandle [hudi]

2023-12-19 Thread via GitHub 


nsivabalan closed pull request #10318: [HUDI-7131] Fixing schema used to read 
base file in HoodieMergedReadHandle
URL: https://github.com/apache/hudi/pull/10318


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [HUDI-7131] Fixing schema used to read base file in HoodieMergedReadHandle [hudi]

2023-12-18 Thread via GitHub 


bvaradar commented on code in PR #10318:
URL: https://github.com/apache/hudi/pull/10318#discussion_r1430909150


##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergedReadHandle.java:
##
@@ -143,7 +145,7 @@ private List> 
doMergedRead(Option baseFileRead
 if (baseFileReaderOpt.isPresent()) {
   HoodieFileReader baseFileReader = baseFileReaderOpt.get();
   HoodieRecordMerger recordMerger = config.getRecordMerger();
-  ClosableIterator> baseFileItr = 
baseFileReader.getRecordIterator(readerSchema);
+  ClosableIterator> baseFileItr = 
baseFileReader.getRecordIterator(baseFileReaderSchema);

Review Comment:
   @nsivabalan : Wouldn't this cause more columns to be read which is not used 
for merging ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [HUDI-7131] Fixing schema used to read base file in HoodieMergedReadHandle [hudi]

2023-12-12 Thread via GitHub 


hudi-bot commented on PR #10318:
URL: https://github.com/apache/hudi/pull/10318#issuecomment-1851946870

   
   ## CI report:
   
   * 32e63551638725305e5b3318816aa4a469399796 Azure: 
[FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21471)
 
   
   
   Bot commands
 @hudi-bot supports the following commands:
   
- `@hudi-bot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [HUDI-7131] Fixing schema used to read base file in HoodieMergedReadHandle [hudi]

2023-12-12 Thread via GitHub 


hudi-bot commented on PR #10318:
URL: https://github.com/apache/hudi/pull/10318#issuecomment-1851799300

   
   ## CI report:
   
   * 32e63551638725305e5b3318816aa4a469399796 Azure: 
[PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21471)
 
   
   
   Bot commands
 @hudi-bot supports the following commands:
   
- `@hudi-bot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [HUDI-7131] Fixing schema used to read base file in HoodieMergedReadHandle [hudi]

2023-12-12 Thread via GitHub 


hudi-bot commented on PR #10318:
URL: https://github.com/apache/hudi/pull/10318#issuecomment-1851786461

   
   ## CI report:
   
   * 32e63551638725305e5b3318816aa4a469399796 UNKNOWN
   
   
   Bot commands
 @hudi-bot supports the following commands:
   
- `@hudi-bot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] [HUDI-7131] Fixing schema used to read base file in HoodieMergedReadHandle [hudi]

2023-12-12 Thread via GitHub 


nsivabalan opened a new pull request, #10318:
URL: https://github.com/apache/hudi/pull/10318

   ### Change Logs
   
   Fixing schema used to read base file in HoodieMergedReadHandle
   
   ### Impact
   
   MIT works for global index use-cases. 
   
   ### Risk level (write none, low medium or high below)
   
   low
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, 
config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the 
default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. 
Please create a Jira ticket, attach the
 ticket number here and follow the 
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to 
make
 changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org