Re: [PR] [HUDI-7351] Implement partition pushdown for glue [hudi]
danny0405 merged PR #10604: URL: https://github.com/apache/hudi/pull/10604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7351] Implement partition pushdown for glue [hudi]
parisni commented on PR #10604: URL: https://github.com/apache/hudi/pull/10604#issuecomment-1925625385 @danny0405 Introduced IT tests for hudi-aws with dockerized moto here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7351] Implement partition pushdown for glue [hudi]
hudi-bot commented on PR #10604: URL: https://github.com/apache/hudi/pull/10604#issuecomment-1925510955 ## CI report: * 8299f34e4d6caba0abbd8a74bb0963c9450b6c35 UNKNOWN * c63161ee0accab529f8e1aef7b1bdff5874edb2b Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22312) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7351] Implement partition pushdown for glue [hudi]
hudi-bot commented on PR #10604: URL: https://github.com/apache/hudi/pull/10604#issuecomment-1925507541 ## CI report: * 8299f34e4d6caba0abbd8a74bb0963c9450b6c35 UNKNOWN * 7b94f04ef4d357dcc7337823d186a2181d3fc997 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22311) * c63161ee0accab529f8e1aef7b1bdff5874edb2b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22312) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7351] Implement partition pushdown for glue [hudi]
hudi-bot commented on PR #10604: URL: https://github.com/apache/hudi/pull/10604#issuecomment-1925482739 ## CI report: * 8299f34e4d6caba0abbd8a74bb0963c9450b6c35 UNKNOWN * 3e3f138597900a7285b45f3df639e6c44b281571 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22293) * 7b94f04ef4d357dcc7337823d186a2181d3fc997 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22311) * c63161ee0accab529f8e1aef7b1bdff5874edb2b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22312) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7351] Implement partition pushdown for glue [hudi]
hudi-bot commented on PR #10604: URL: https://github.com/apache/hudi/pull/10604#issuecomment-1925481257 ## CI report: * 8299f34e4d6caba0abbd8a74bb0963c9450b6c35 UNKNOWN * 3e3f138597900a7285b45f3df639e6c44b281571 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22293) * 7b94f04ef4d357dcc7337823d186a2181d3fc997 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22311) * c63161ee0accab529f8e1aef7b1bdff5874edb2b UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7351] Implement partition pushdown for glue [hudi]
hudi-bot commented on PR #10604: URL: https://github.com/apache/hudi/pull/10604#issuecomment-1925470031 ## CI report: * 8299f34e4d6caba0abbd8a74bb0963c9450b6c35 UNKNOWN * 3e3f138597900a7285b45f3df639e6c44b281571 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22293) * 7b94f04ef4d357dcc7337823d186a2181d3fc997 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22311) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7351] Implement partition pushdown for glue [hudi]
hudi-bot commented on PR #10604: URL: https://github.com/apache/hudi/pull/10604#issuecomment-1925468723 ## CI report: * 8299f34e4d6caba0abbd8a74bb0963c9450b6c35 UNKNOWN * 3e3f138597900a7285b45f3df639e6c44b281571 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22293) * 7b94f04ef4d357dcc7337823d186a2181d3fc997 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7351] Implement partition pushdown for glue [hudi]
parisni commented on PR #10604: URL: https://github.com/apache/hudi/pull/10604#issuecomment-1924879580 BTW @danny0405 I am working on a POC for IT test with moto to improve the reliability of this module https://github.com/apache/hudi/pull/10614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7351] Implement partition pushdown for glue [hudi]
hudi-bot commented on PR #10604: URL: https://github.com/apache/hudi/pull/10604#issuecomment-1923753603 ## CI report: * 8299f34e4d6caba0abbd8a74bb0963c9450b6c35 UNKNOWN * 3e3f138597900a7285b45f3df639e6c44b281571 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22293) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7351] Implement partition pushdown for glue [hudi]
hudi-bot commented on PR #10604: URL: https://github.com/apache/hudi/pull/10604#issuecomment-1923494239 ## CI report: * 8299f34e4d6caba0abbd8a74bb0963c9450b6c35 UNKNOWN * 9b3f2ebbfbdcd615d407ef89e0c4575e6c3f669b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22278) * 3e3f138597900a7285b45f3df639e6c44b281571 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22293) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7351] Implement partition pushdown for glue [hudi]
hudi-bot commented on PR #10604: URL: https://github.com/apache/hudi/pull/10604#issuecomment-1923482651 ## CI report: * 8299f34e4d6caba0abbd8a74bb0963c9450b6c35 UNKNOWN * 9b3f2ebbfbdcd615d407ef89e0c4575e6c3f669b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22278) * 3e3f138597900a7285b45f3df639e6c44b281571 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7351] Implement partition pushdown for glue [hudi]
parisni commented on PR #10604: URL: https://github.com/apache/hudi/pull/10604#issuecomment-1923447852 I e2e tested locally. We will land this patch next week in production so let me confirm it's all right then. BTW I added a refacto let me know if it's better -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7351] Implement partition pushdown for glue [hudi]
danny0405 commented on PR #10604: URL: https://github.com/apache/hudi/pull/10604#issuecomment-1922602186 There are no UT, can you ensure the functionality by offline e2e tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7351] Implement partition pushdown for glue [hudi]
hudi-bot commented on PR #10604: URL: https://github.com/apache/hudi/pull/10604#issuecomment-1922509381 ## CI report: * 8299f34e4d6caba0abbd8a74bb0963c9450b6c35 UNKNOWN * 9b3f2ebbfbdcd615d407ef89e0c4575e6c3f669b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22278) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7351] Implement partition pushdown for glue [hudi]
hudi-bot commented on PR #10604: URL: https://github.com/apache/hudi/pull/10604#issuecomment-1922341290 ## CI report: * 8299f34e4d6caba0abbd8a74bb0963c9450b6c35 UNKNOWN * 9b3f2ebbfbdcd615d407ef89e0c4575e6c3f669b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22278) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7351] Implement partition pushdown for glue [hudi]
hudi-bot commented on PR #10604: URL: https://github.com/apache/hudi/pull/10604#issuecomment-1922328981 ## CI report: * 8299f34e4d6caba0abbd8a74bb0963c9450b6c35 UNKNOWN * 9b3f2ebbfbdcd615d407ef89e0c4575e6c3f669b UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7351] Implement partition pushdown for glue [hudi]
hudi-bot commented on PR #10604: URL: https://github.com/apache/hudi/pull/10604#issuecomment-1922254233 ## CI report: * 8299f34e4d6caba0abbd8a74bb0963c9450b6c35 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7351] Implement partition pushdown for glue [hudi]
parisni commented on PR #10604: URL: https://github.com/apache/hudi/pull/10604#issuecomment-1922252363 @danny0405 you were involved in the previous PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [HUDI-7351] Implement partition pushdown for glue [hudi]
parisni opened a new pull request, #10604: URL: https://github.com/apache/hudi/pull/10604 ### Change Logs This is a follow up of #10572 While the mentioned PR fixed the runtime error, it did not implement the logic for pushdown. The current PR does so by: - refactor to enable one implementation of pushdown per sync client - provide a glue expression (diverge from hms) - reorder the partitions in case they are returned misordered by the metastore - optimize partition retrieval by missing the columns details ### Impact Using this feature has proven faster metastore sync in case of large number of partitions, from couple of minutes to seconds. ### Risk level (write none, low medium or high below) None ### Documentation Update _Describe any necessary documentation update if there is any new feature, config, or user-facing change_ - _The config description must be updated if new configs are added or the default value of the configs are changed_ - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make changes to the website._ ### Contributor's checklist - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute) - [ ] Change Logs and Impact were stated clearly - [ ] Adequate tests were added if applicable - [ ] CI passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
