Re: [PR] [HUDI-7373] Make schema evolution doc and config correct [hudi]

2024-02-20 Thread via GitHub


jonvex merged PR #10612:
URL: https://github.com/apache/hudi/pull/10612


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HUDI-7373] Make schema evolution doc and config correct [hudi]

2024-02-20 Thread via GitHub


jonvex commented on code in PR #10612:
URL: https://github.com/apache/hudi/pull/10612#discussion_r1496076240


##
website/docs/configurations.md:
##
@@ -127,59 +127,59 @@ Options useful for writing tables via 
`write.format.option(...)`
 [**Advanced Configs**](#Write-Options-advanced-configs)
 
 
-| Config Name  
| Default   
   | Description









  

|
-| 

 |  | 
-
 
--
 |
-| 
[hoodie.datasource.hive_sync.serde_properties](#hoodiedatasourcehive_syncserde_properties)
   | (N/A)  
  | Serde properties to hive table.`Config Param: HIVE_TABLE_SERDE_PROPERTIES`   








  

|
-| 
[hoodie.datasource.hive_sync.table_properties](#hoodiedatasourcehive_synctable_properties)
   | (N/A)  
  | Additional properties to store with 
table.`Config Param: HIVE_TABLE_PROPERTIES`   








 

|
-| [hoodie.datasource.overwrite.mode](#hoodiedatasourceoverwritemode)   
| (N/A) 
   | Controls whether overwrite 
use dynamic or static mode, if not configured, respect 

Re: [PR] [HUDI-7373] Make schema evolution doc and config correct [hudi]

2024-02-06 Thread via GitHub


jonvex commented on code in PR #10612:
URL: https://github.com/apache/hudi/pull/10612#discussion_r1480130374


##
website/docs/configurations.md:
##
@@ -127,59 +127,59 @@ Options useful for writing tables via 
`write.format.option(...)`
 [**Advanced Configs**](#Write-Options-advanced-configs)
 
 
-| Config Name  
| Default   
   | Description









  

|
-| 

 |  | 
-
 
--
 |
-| 
[hoodie.datasource.hive_sync.serde_properties](#hoodiedatasourcehive_syncserde_properties)
   | (N/A)  
  | Serde properties to hive table.`Config Param: HIVE_TABLE_SERDE_PROPERTIES`   








  

|
-| 
[hoodie.datasource.hive_sync.table_properties](#hoodiedatasourcehive_synctable_properties)
   | (N/A)  
  | Additional properties to store with 
table.`Config Param: HIVE_TABLE_PROPERTIES`   








 

|
-| [hoodie.datasource.overwrite.mode](#hoodiedatasourceoverwritemode)   
| (N/A) 
   | Controls whether overwrite 
use dynamic or static mode, if not configured, respect 

Re: [PR] [HUDI-7373] Make schema evolution doc and config correct [hudi]

2024-02-06 Thread via GitHub


nsivabalan commented on code in PR #10612:
URL: https://github.com/apache/hudi/pull/10612#discussion_r1479356893


##
website/docs/configurations.md:
##
@@ -127,59 +127,59 @@ Options useful for writing tables via 
`write.format.option(...)`
 [**Advanced Configs**](#Write-Options-advanced-configs)
 
 
-| Config Name  
| Default   
   | Description









  

|
-| 

 |  | 
-
 
--
 |
-| 
[hoodie.datasource.hive_sync.serde_properties](#hoodiedatasourcehive_syncserde_properties)
   | (N/A)  
  | Serde properties to hive table.`Config Param: HIVE_TABLE_SERDE_PROPERTIES`   








  

|
-| 
[hoodie.datasource.hive_sync.table_properties](#hoodiedatasourcehive_synctable_properties)
   | (N/A)  
  | Additional properties to store with 
table.`Config Param: HIVE_TABLE_PROPERTIES`   








 

|
-| [hoodie.datasource.overwrite.mode](#hoodiedatasourceoverwritemode)   
| (N/A) 
   | Controls whether overwrite 
use dynamic or static mode, if not configured, respect 

[PR] [HUDI-7373] Make schema evolution doc and config correct [hudi]

2024-02-02 Thread via GitHub


jonvex opened a new pull request, #10612:
URL: https://github.com/apache/hudi/pull/10612

   ### Change Logs
   
   hoodie.write.set.null.for.missing.columns was renamed to
   
   hoodie.write.handle.missing.cols.with.lossless.type.promotion. The config 
only adds the missing columns. The "reverse type promotion" is not controlled 
by a config. Additionally, this commit never made it to the release, so 
hoodie.write.handle.missing.cols.with.lossless.type.promotion will not work, 
only hoodie.write.set.null.for.missing.columns .
   
   ### Impact
   
   Users can get the correct config
   
   ### Risk level (write none, low medium or high below)
   
   none
   
   ### Documentation Update
   
   N/A
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org