Re: [PR] [HUDI-7407] Making clean optional in standalone compaction and clustering jobs [hudi]
codope merged PR #10668: URL: https://github.com/apache/hudi/pull/10668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7407] Making clean optional in standalone compaction and clustering jobs [hudi]
hudi-bot commented on PR #10668: URL: https://github.com/apache/hudi/pull/10668#issuecomment-2139636243 ## CI report: * 5a6c7723f716d5719a8011150f73077ab1ba3a1f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24145) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7407] Making clean optional in standalone compaction and clustering jobs [hudi]
hudi-bot commented on PR #10668: URL: https://github.com/apache/hudi/pull/10668#issuecomment-2139516375 ## CI report: * b24eafcc00d5cf4a27ae7f9d7e70b1bfc5a12b1a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24111) * 5a6c7723f716d5719a8011150f73077ab1ba3a1f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24145) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7407] Making clean optional in standalone compaction and clustering jobs [hudi]
hudi-bot commented on PR #10668: URL: https://github.com/apache/hudi/pull/10668#issuecomment-2139501982 ## CI report: * b24eafcc00d5cf4a27ae7f9d7e70b1bfc5a12b1a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24111) * 5a6c7723f716d5719a8011150f73077ab1ba3a1f UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7407] Making clean optional in standalone compaction and clustering jobs [hudi]
codope commented on code in PR #10668:
URL: https://github.com/apache/hudi/pull/10668#discussion_r1620652100
##
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieClusteringJob.java:
##
@@ -92,6 +92,8 @@ public static class Config implements Serializable {
public String sparkMemory = null;
@Parameter(names = {"--retry", "-rt"}, description = "number of retries")
public int retry = 0;
+@Parameter(names = {"--skip-clean", "-sc"}, description = "do not trigger
clean after compaction", required = false)
+public Boolean skipClean = true;
Review Comment:
not changing.. should be fine as it's an offline job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HUDI-7407] Making clean optional in standalone compaction and clustering jobs [hudi]
codope commented on code in PR #10668:
URL: https://github.com/apache/hudi/pull/10668#discussion_r1618485348
##
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieClusteringJob.java:
##
@@ -92,6 +92,8 @@ public static class Config implements Serializable {
public String sparkMemory = null;
@Parameter(names = {"--retry", "-rt"}, description = "number of retries")
public int retry = 0;
+@Parameter(names = {"--skip-clean", "-sc"}, description = "do not trigger
clean after compaction", required = false)
+public Boolean skipClean = true;
Review Comment:
should default be false to conform to existing behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HUDI-7407] Making clean optional in standalone compaction and clustering jobs [hudi]
hudi-bot commented on PR #10668: URL: https://github.com/apache/hudi/pull/10668#issuecomment-2136678726 ## CI report: * b24eafcc00d5cf4a27ae7f9d7e70b1bfc5a12b1a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24111) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7407] Making clean optional in standalone compaction and clustering jobs [hudi]
hudi-bot commented on PR #10668: URL: https://github.com/apache/hudi/pull/10668#issuecomment-2136577547 ## CI report: * 1b2ecc10deaab20be3ff90ccf2e4510a6d2e1d41 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23797) * b24eafcc00d5cf4a27ae7f9d7e70b1bfc5a12b1a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24111) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7407] Making clean optional in standalone compaction and clustering jobs [hudi]
hudi-bot commented on PR #10668: URL: https://github.com/apache/hudi/pull/10668#issuecomment-2136568814 ## CI report: * 1b2ecc10deaab20be3ff90ccf2e4510a6d2e1d41 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23797) * b24eafcc00d5cf4a27ae7f9d7e70b1bfc5a12b1a UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7407] Making clean optional in standalone compaction and clustering jobs [hudi]
nsivabalan commented on PR #10668: URL: https://github.com/apache/hudi/pull/10668#issuecomment-2136556906 @codope : ready to review. fixed the test failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7407] Making clean optional in standalone compaction and clustering jobs [hudi]
nsivabalan commented on PR #10668: URL: https://github.com/apache/hudi/pull/10668#issuecomment-2103415416 not really a blocker as such. we can punt this if we are strapped for time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7407] Making clean optional in standalone compaction and clustering jobs [hudi]
hudi-bot commented on PR #10668: URL: https://github.com/apache/hudi/pull/10668#issuecomment-2103290406 ## CI report: * 1b2ecc10deaab20be3ff90ccf2e4510a6d2e1d41 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23797) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7407] Making clean optional in standalone compaction and clustering jobs [hudi]
hudi-bot commented on PR #10668: URL: https://github.com/apache/hudi/pull/10668#issuecomment-2103228251 ## CI report: * 4efbcf64fa7e047112c8cb3e64d106d804e39d92 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23685) * 1b2ecc10deaab20be3ff90ccf2e4510a6d2e1d41 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23797) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7407] Making clean optional in standalone compaction and clustering jobs [hudi]
hudi-bot commented on PR #10668: URL: https://github.com/apache/hudi/pull/10668#issuecomment-2103217040 ## CI report: * 4efbcf64fa7e047112c8cb3e64d106d804e39d92 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23685) * 1b2ecc10deaab20be3ff90ccf2e4510a6d2e1d41 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7407] Making clean optional in standalone compaction and clustering jobs [hudi]
hudi-bot commented on PR #10668: URL: https://github.com/apache/hudi/pull/10668#issuecomment-2095424769 ## CI report: * 4efbcf64fa7e047112c8cb3e64d106d804e39d92 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23685) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7407] Making clean optional in standalone compaction and clustering jobs [hudi]
hudi-bot commented on PR #10668: URL: https://github.com/apache/hudi/pull/10668#issuecomment-2095357015 ## CI report: * 6e054ff5a4005e039b7af656993758882db0ec21 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22439) * 4efbcf64fa7e047112c8cb3e64d106d804e39d92 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23685) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7407] Making clean optional in standalone compaction and clustering jobs [hudi]
hudi-bot commented on PR #10668: URL: https://github.com/apache/hudi/pull/10668#issuecomment-2095345534 ## CI report: * 6e054ff5a4005e039b7af656993758882db0ec21 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22439) * 4efbcf64fa7e047112c8cb3e64d106d804e39d92 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
