Re: [PR] [HUDI-7599] add bootstrap mor legacy reader back to default source [hudi]
yihua merged PR #10990: URL: https://github.com/apache/hudi/pull/10990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7599] add bootstrap mor legacy reader back to default source [hudi]
hudi-bot commented on PR #10990: URL: https://github.com/apache/hudi/pull/10990#issuecomment-2050201350 ## CI report: * f255df62c32db35a7611d14c3fe4aed080f08b12 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23193) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7599] add bootstrap mor legacy reader back to default source [hudi]
hudi-bot commented on PR #10990: URL: https://github.com/apache/hudi/pull/10990#issuecomment-2050009526 ## CI report: * 7efcbe962e93a3c0be35debf30684afeb96095c5 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23184) * f255df62c32db35a7611d14c3fe4aed080f08b12 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23193) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7599] add bootstrap mor legacy reader back to default source [hudi]
hudi-bot commented on PR #10990: URL: https://github.com/apache/hudi/pull/10990#issuecomment-2049994175 ## CI report: * 7efcbe962e93a3c0be35debf30684afeb96095c5 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23184) * f255df62c32db35a7611d14c3fe4aed080f08b12 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7599] add bootstrap mor legacy reader back to default source [hudi]
jonvex commented on code in PR #10990:
URL: https://github.com/apache/hudi/pull/10990#discussion_r1561221556
##
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DefaultSource.scala:
##
@@ -299,14 +299,22 @@ object DefaultSource {
new IncrementalRelation(sqlContext, parameters, userSchema,
metaClient)
}
- case (MERGE_ON_READ, QUERY_TYPE_SNAPSHOT_OPT_VAL, _) =>
+ case (MERGE_ON_READ, QUERY_TYPE_SNAPSHOT_OPT_VAL, false) =>
if (useNewParquetFileFormat) {
new HoodieMergeOnReadSnapshotHadoopFsRelationFactory(
-sqlContext, metaClient, parameters, userSchema,
isBootstrappedTable).build()
+sqlContext, metaClient, parameters, userSchema, isBootstrap =
false).build()
} else {
new MergeOnReadSnapshotRelation(sqlContext, parameters,
metaClient, globPaths, userSchema)
}
+ case (MERGE_ON_READ, QUERY_TYPE_SNAPSHOT_OPT_VAL, true) =>
Review Comment:
enabled some tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HUDI-7599] add bootstrap mor legacy reader back to default source [hudi]
hudi-bot commented on PR #10990: URL: https://github.com/apache/hudi/pull/10990#issuecomment-2048923370 ## CI report: * 7efcbe962e93a3c0be35debf30684afeb96095c5 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23184) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7599] add bootstrap mor legacy reader back to default source [hudi]
hudi-bot commented on PR #10990: URL: https://github.com/apache/hudi/pull/10990#issuecomment-2048840404 ## CI report: * 8522c4683328ac7aadbc42bd9b69485d3bbdc720 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23177) * 7efcbe962e93a3c0be35debf30684afeb96095c5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23184) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7599] add bootstrap mor legacy reader back to default source [hudi]
hudi-bot commented on PR #10990: URL: https://github.com/apache/hudi/pull/10990#issuecomment-2048835526 ## CI report: * 8522c4683328ac7aadbc42bd9b69485d3bbdc720 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23177) * 7efcbe962e93a3c0be35debf30684afeb96095c5 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7599] add bootstrap mor legacy reader back to default source [hudi]
yihua commented on code in PR #10990:
URL: https://github.com/apache/hudi/pull/10990#discussion_r1560201092
##
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DefaultSource.scala:
##
@@ -299,14 +299,22 @@ object DefaultSource {
new IncrementalRelation(sqlContext, parameters, userSchema,
metaClient)
}
- case (MERGE_ON_READ, QUERY_TYPE_SNAPSHOT_OPT_VAL, _) =>
+ case (MERGE_ON_READ, QUERY_TYPE_SNAPSHOT_OPT_VAL, false) =>
if (useNewParquetFileFormat) {
new HoodieMergeOnReadSnapshotHadoopFsRelationFactory(
-sqlContext, metaClient, parameters, userSchema,
isBootstrappedTable).build()
+sqlContext, metaClient, parameters, userSchema, isBootstrap =
false).build()
} else {
new MergeOnReadSnapshotRelation(sqlContext, parameters,
metaClient, globPaths, userSchema)
}
+ case (MERGE_ON_READ, QUERY_TYPE_SNAPSHOT_OPT_VAL, true) =>
Review Comment:
Do we need a new test case on this given CI passes without catching this
before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HUDI-7599] add bootstrap mor legacy reader back to default source [hudi]
hudi-bot commented on PR #10990: URL: https://github.com/apache/hudi/pull/10990#issuecomment-2048386936 ## CI report: * 8522c4683328ac7aadbc42bd9b69485d3bbdc720 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23177) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7599] add bootstrap mor legacy reader back to default source [hudi]
hudi-bot commented on PR #10990: URL: https://github.com/apache/hudi/pull/10990#issuecomment-2048204294 ## CI report: * 8522c4683328ac7aadbc42bd9b69485d3bbdc720 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23177) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7599] add bootstrap mor legacy reader back to default source [hudi]
hudi-bot commented on PR #10990: URL: https://github.com/apache/hudi/pull/10990#issuecomment-2048139565 ## CI report: * 8522c4683328ac7aadbc42bd9b69485d3bbdc720 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [HUDI-7599] add bootstrap mor legacy reader back to default source [hudi]
jonvex opened a new pull request, #10990: URL: https://github.com/apache/hudi/pull/10990 ### Change Logs Was accidentally removed by https://github.com/apache/hudi/pull/10304 TestNewHoodieParquetFileFormat will pass now ### Impact legacy reader now has bootstrap mor functionality ### Risk level (write none, low medium or high below) none ### Documentation Update N/A ### Contributor's checklist - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute) - [ ] Change Logs and Impact were stated clearly - [ ] Adequate tests were added if applicable - [ ] CI passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
