Re: [PR] [HUDI-7608] Fix Flink table creation configuration not taking effect when writing… [hudi]
danny0405 merged PR #11005: URL: https://github.com/apache/hudi/pull/11005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7608] Fix Flink table creation configuration not taking effect when writing… [hudi]
hudi-bot commented on PR #11005: URL: https://github.com/apache/hudi/pull/11005#issuecomment-2071392425 ## CI report: * ca0a152dc4a05040f2e42549e2d579018f21c465 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23408) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7608] Fix Flink table creation configuration not taking effect when writing… [hudi]
hudi-bot commented on PR #11005: URL: https://github.com/apache/hudi/pull/11005#issuecomment-2071341811 ## CI report: * 3407c64c5a499b22d1d1e2c713306d7d70ccc19d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23400) * ca0a152dc4a05040f2e42549e2d579018f21c465 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23408) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7608] Fix Flink table creation configuration not taking effect when writing… [hudi]
hudi-bot commented on PR #11005: URL: https://github.com/apache/hudi/pull/11005#issuecomment-2071336473 ## CI report: * 3407c64c5a499b22d1d1e2c713306d7d70ccc19d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23400) * ca0a152dc4a05040f2e42549e2d579018f21c465 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7608] Fix Flink table creation configuration not taking effect when writing… [hudi]
danny0405 commented on PR #11005: URL: https://github.com/apache/hudi/pull/11005#issuecomment-2071238901 There are some compile errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7608] Fix Flink table creation configuration not taking effect when writing… [hudi]
hudi-bot commented on PR #11005: URL: https://github.com/apache/hudi/pull/11005#issuecomment-2070525308 ## CI report: * 3407c64c5a499b22d1d1e2c713306d7d70ccc19d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23400) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7608] Fix Flink table creation configuration not taking effect when writing… [hudi]
hudi-bot commented on PR #11005: URL: https://github.com/apache/hudi/pull/11005#issuecomment-2070312501 ## CI report: * 103687899ff6b98c1961a693dd674a35746d9e39 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23398) * 3407c64c5a499b22d1d1e2c713306d7d70ccc19d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23400) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7608] Fix Flink table creation configuration not taking effect when writing… [hudi]
hudi-bot commented on PR #11005: URL: https://github.com/apache/hudi/pull/11005#issuecomment-2070157544 ## CI report: * 103687899ff6b98c1961a693dd674a35746d9e39 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23398) * 3407c64c5a499b22d1d1e2c713306d7d70ccc19d UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7608] Fix Flink table creation configuration not taking effect when writing… [hudi]
hudi-bot commented on PR #11005: URL: https://github.com/apache/hudi/pull/11005#issuecomment-2070101870 ## CI report: * 103687899ff6b98c1961a693dd674a35746d9e39 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23398) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7608] Fix Flink table creation configuration not taking effect when writing… [hudi]
hudi-bot commented on PR #11005: URL: https://github.com/apache/hudi/pull/11005#issuecomment-2069923631 ## CI report: * 31be1b14c714e549548033084c41a8b93b331b3c Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23253) * 103687899ff6b98c1961a693dd674a35746d9e39 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23398) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7608] Fix Flink table creation configuration not taking effect when writing… [hudi]
hudi-bot commented on PR #11005: URL: https://github.com/apache/hudi/pull/11005#issuecomment-2069890345 ## CI report: * 31be1b14c714e549548033084c41a8b93b331b3c Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23253) * 103687899ff6b98c1961a693dd674a35746d9e39 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7608] Fix Flink table creation configuration not taking effect when writing… [hudi]
empcl commented on code in PR #11005:
URL: https://github.com/apache/hudi/pull/11005#discussion_r1574947814
##
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/HoodieOptionConfig.scala:
##
@@ -43,6 +43,11 @@ object HoodieOptionConfig {
*/
val SQL_VALUE_TABLE_TYPE_MOR = "mor"
+ /**
+ * The short name for the value of index type.
+ */
+ val SQL_VALUE_INDEX_TYPE = "index.type"
Review Comment:
I have referred to your suggestions for modification.When creating a table
in Flink, convert `index.type` to `hoodie.index.type`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HUDI-7608] Fix Flink table creation configuration not taking effect when writing… [hudi]
empcl commented on code in PR #11005:
URL: https://github.com/apache/hudi/pull/11005#discussion_r1574947814
##
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/HoodieOptionConfig.scala:
##
@@ -43,6 +43,11 @@ object HoodieOptionConfig {
*/
val SQL_VALUE_TABLE_TYPE_MOR = "mor"
+ /**
+ * The short name for the value of index type.
+ */
+ val SQL_VALUE_INDEX_TYPE = "index.type"
Review Comment:
I have referred to your suggestions for modification.When creating a table
in Flink, convert index.type to hoodie.index.type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HUDI-7608] Fix Flink table creation configuration not taking effect when writing… [hudi]
danny0405 commented on code in PR #11005:
URL: https://github.com/apache/hudi/pull/11005#discussion_r1566579977
##
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/HoodieOptionConfig.scala:
##
@@ -43,6 +43,11 @@ object HoodieOptionConfig {
*/
val SQL_VALUE_TABLE_TYPE_MOR = "mor"
+ /**
+ * The short name for the value of index type.
+ */
+ val SQL_VALUE_INDEX_TYPE = "index.type"
Review Comment:
`index.type` is a short-cut name only for Flink now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HUDI-7608] Fix Flink table creation configuration not taking effect when writing… [hudi]
hudi-bot commented on PR #11005: URL: https://github.com/apache/hudi/pull/11005#issuecomment-2056315915 ## CI report: * 31be1b14c714e549548033084c41a8b93b331b3c Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23253) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7608] Fix Flink table creation configuration not taking effect when writing… [hudi]
hudi-bot commented on PR #11005: URL: https://github.com/apache/hudi/pull/11005#issuecomment-2055748819 ## CI report: * c0ca195bf69614784e60bd51d300df04a61fdf21 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23216) * 31be1b14c714e549548033084c41a8b93b331b3c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23253) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7608] Fix Flink table creation configuration not taking effect when writing… [hudi]
hudi-bot commented on PR #11005: URL: https://github.com/apache/hudi/pull/11005#issuecomment-2055715653 ## CI report: * c0ca195bf69614784e60bd51d300df04a61fdf21 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23216) * 31be1b14c714e549548033084c41a8b93b331b3c UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7608] Fix Flink table creation configuration not taking effect when writing… [hudi]
empcl commented on code in PR #11005:
URL: https://github.com/apache/hudi/pull/11005#discussion_r1565245821
##
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/HoodieOptionConfig.scala:
##
@@ -43,6 +43,11 @@ object HoodieOptionConfig {
*/
val SQL_VALUE_TABLE_TYPE_MOR = "mor"
+ /**
+ * The short name for the value of index type.
+ */
+ val SQL_VALUE_INDEX_TYPE = "index.type"
Review Comment:
This issue exists in various Spark versions, such as 2.4, 3.0, etc., while
org. apache. park. SQL. hudi. catalog The implementation of HoodieCatalog is
only available at 3.2 and above. My current modification is in the
configuration of merging Hoodie CatalogTable catalog properties and hoodie.
properties records, so I think it is acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HUDI-7608] Fix Flink table creation configuration not taking effect when writing… [hudi]
danny0405 commented on code in PR #11005:
URL: https://github.com/apache/hudi/pull/11005#discussion_r1563423256
##
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/HoodieOptionConfig.scala:
##
@@ -43,6 +43,11 @@ object HoodieOptionConfig {
*/
val SQL_VALUE_TABLE_TYPE_MOR = "mor"
+ /**
+ * The short name for the value of index type.
+ */
+ val SQL_VALUE_INDEX_TYPE = "index.type"
Review Comment:
Maybe we can fix the options in hudi catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HUDI-7608] Fix Flink table creation configuration not taking effect when writing… [hudi]
hudi-bot commented on PR #11005: URL: https://github.com/apache/hudi/pull/11005#issuecomment-2051683072 ## CI report: * c0ca195bf69614784e60bd51d300df04a61fdf21 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23216) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7608] Fix Flink table creation configuration not taking effect when writing… [hudi]
hudi-bot commented on PR #11005: URL: https://github.com/apache/hudi/pull/11005#issuecomment-2051533385 ## CI report: * c0ca195bf69614784e60bd51d300df04a61fdf21 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23216) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7608] Fix Flink table creation configuration not taking effect when writing… [hudi]
hudi-bot commented on PR #11005: URL: https://github.com/apache/hudi/pull/11005#issuecomment-2051522148 ## CI report: * c0ca195bf69614784e60bd51d300df04a61fdf21 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [HUDI-7608] Fix Flink table creation configuration not taking effect when writing… [hudi]
empcl opened a new pull request, #11005: URL: https://github.com/apache/hudi/pull/11005 … to Spark ### Change Logs Fix Flink table creation configuration not taking effect when writing to Spark ### Impact _none._ ### Risk level (write none, low medium or high below) _none._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
