Re: [PR] [HUDI-7743] Improve StoragePath usages [hudi]
yihua merged PR #11189: URL: https://github.com/apache/hudi/pull/11189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7743] Improve StoragePath usages [hudi]
hudi-bot commented on PR #11189: URL: https://github.com/apache/hudi/pull/11189#issuecomment-2106534204 ## CI report: * 4095b60ef4c272c8046aeb9e2a1d13db2d1c0a9d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23865) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7743] Improve StoragePath usages [hudi]
hudi-bot commented on PR #11189: URL: https://github.com/apache/hudi/pull/11189#issuecomment-2106449606 ## CI report: * 511e55b8d042e8db674b48b203f3bf9b8f52ad6e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23858) * 4095b60ef4c272c8046aeb9e2a1d13db2d1c0a9d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23865) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7743] Improve StoragePath usages [hudi]
hudi-bot commented on PR #11189: URL: https://github.com/apache/hudi/pull/11189#issuecomment-210660 ## CI report: * 511e55b8d042e8db674b48b203f3bf9b8f52ad6e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23858) * 4095b60ef4c272c8046aeb9e2a1d13db2d1c0a9d UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7743] Improve StoragePath usages [hudi]
yihua commented on code in PR #11189:
URL: https://github.com/apache/hudi/pull/11189#discussion_r1597754130
##
hudi-common/src/main/java/org/apache/hudi/common/table/view/IncrementalTimelineSyncFileSystemView.java:
##
@@ -269,7 +269,7 @@ private void updatePartitionWriteFileGroups(Map> p
LOG.info("Syncing partition (" + partition + ") of instant (" +
instant + ")");
List pathInfoList = entry.getValue().stream()
.map(p -> new StoragePathInfo(
-new StoragePath(String.format("%s/%s",
metaClient.getBasePath(), p.getPath())),
+new StoragePath(metaClient.getBasePathV2(), p.getPath()),
Review Comment:
If p.getPath() has a slash as the prefix, there will be a behavior change.
##
hudi-common/src/main/java/org/apache/hudi/common/table/view/IncrementalTimelineSyncFileSystemView.java:
##
@@ -269,7 +269,7 @@ private void updatePartitionWriteFileGroups(Map> p
LOG.info("Syncing partition (" + partition + ") of instant (" +
instant + ")");
List pathInfoList = entry.getValue().stream()
.map(p -> new StoragePathInfo(
-new StoragePath(String.format("%s/%s",
metaClient.getBasePath(), p.getPath())),
+new StoragePath(metaClient.getBasePathV2(), p.getPath()),
Review Comment:
```suggestion
new StoragePath(String.format("%s/%s",
metaClient.getBasePath(), p.getPath())),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HUDI-7743] Improve StoragePath usages [hudi]
yihua commented on code in PR #11189:
URL: https://github.com/apache/hudi/pull/11189#discussion_r1597753236
##
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedMetadata.java:
##
@@ -2040,7 +2040,7 @@ public void testEagerRollbackinMDT() throws IOException {
// collect all commit meta files from metadata table.
List metaFiles = metaClient.getStorage()
-.listDirectEntries(new StoragePath(metaClient.getMetaPath() +
"/metadata/.hoodie"));
+.listDirectEntries(new StoragePath(metaClient.getMetaPath(),
"/metadata/.hoodie"));
Review Comment:
```suggestion
.listDirectEntries(new StoragePath(metaClient.getMetaPath(),
"metadata/.hoodie"));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HUDI-7743] Improve StoragePath usages [hudi]
hudi-bot commented on PR #11189: URL: https://github.com/apache/hudi/pull/11189#issuecomment-2105984164 ## CI report: * 511e55b8d042e8db674b48b203f3bf9b8f52ad6e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23858) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7743] Improve StoragePath usages [hudi]
hudi-bot commented on PR #11189: URL: https://github.com/apache/hudi/pull/11189#issuecomment-2105968110 ## CI report: * fc5e90ed51e7c4151832c3a6c756d4b9ef93131f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23856) * 511e55b8d042e8db674b48b203f3bf9b8f52ad6e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23858) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7743] Improve StoragePath usages [hudi]
hudi-bot commented on PR #11189: URL: https://github.com/apache/hudi/pull/11189#issuecomment-2105965828 ## CI report: * fc5e90ed51e7c4151832c3a6c756d4b9ef93131f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23856) * 511e55b8d042e8db674b48b203f3bf9b8f52ad6e UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7743] Improve StoragePath usages [hudi]
hudi-bot commented on PR #11189: URL: https://github.com/apache/hudi/pull/11189#issuecomment-2105950146 ## CI report: * fc5e90ed51e7c4151832c3a6c756d4b9ef93131f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23856) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7743] Improve StoragePath usages [hudi]
hudi-bot commented on PR #11189: URL: https://github.com/apache/hudi/pull/11189#issuecomment-2105948149 ## CI report: * fc5e90ed51e7c4151832c3a6c756d4b9ef93131f UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7743] Improve StoragePath usages [hudi]
hudi-bot commented on PR #11189: URL: https://github.com/apache/hudi/pull/11189#issuecomment-2105934253 ## CI report: * 975a7d92617080bb4c32e832796e8d13cd8d9857 UNKNOWN * fc5e90ed51e7c4151832c3a6c756d4b9ef93131f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23856) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7743] Improve StoragePath usages [hudi]
hudi-bot commented on PR #11189: URL: https://github.com/apache/hudi/pull/11189#issuecomment-2105911836 ## CI report: * 975a7d92617080bb4c32e832796e8d13cd8d9857 UNKNOWN * 76ee9ca6a701a2fcaa70fce9aae46864486c8c45 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23849) * fc5e90ed51e7c4151832c3a6c756d4b9ef93131f UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7743] Improve StoragePath usages [hudi]
jonvex commented on code in PR #11189: URL: https://github.com/apache/hudi/pull/11189#discussion_r1597457778 ## hudi-cli/src/main/java/org/apache/hudi/cli/commands/RepairsCommand.java: ## @@ -123,7 +121,7 @@ public String addPartitionMeta( client.getActiveTimeline().getCommitTimeline().lastInstant().get().getTimestamp(); List partitionPaths = FSUtils.getAllPartitionFoldersThreeLevelsDown(HoodieCLI.storage, client.getBasePath()); -StoragePath basePath = new StoragePath(client.getBasePath()); +StoragePath basePath = client.getBasePathV2(); Review Comment: https://issues.apache.org/jira/browse/HUDI-7747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7743] Improve StoragePath usages [hudi]
hudi-bot commented on PR #11189: URL: https://github.com/apache/hudi/pull/11189#issuecomment-2105571920 ## CI report: * 975a7d92617080bb4c32e832796e8d13cd8d9857 UNKNOWN * 76ee9ca6a701a2fcaa70fce9aae46864486c8c45 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23849) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7743] Improve StoragePath usages [hudi]
hudi-bot commented on PR #11189: URL: https://github.com/apache/hudi/pull/11189#issuecomment-2105545250 ## CI report: * 975a7d92617080bb4c32e832796e8d13cd8d9857 UNKNOWN * 51a199199691df091162a3d8cb71f9ee448b079a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23829) * 76ee9ca6a701a2fcaa70fce9aae46864486c8c45 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23849) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7743] Improve StoragePath usages [hudi]
hudi-bot commented on PR #11189: URL: https://github.com/apache/hudi/pull/11189#issuecomment-2105540642 ## CI report: * 975a7d92617080bb4c32e832796e8d13cd8d9857 UNKNOWN * 51a199199691df091162a3d8cb71f9ee448b079a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23829) * 76ee9ca6a701a2fcaa70fce9aae46864486c8c45 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
